-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move to official navigraph SDK for charts and authentication #8676
Merged
Benjozork
merged 21 commits into
flybywiresim:master
from
Benjozork:refactor/move-to-navigraph-sdk
Jun 17, 2024
Merged
refactor: move to official navigraph SDK for charts and authentication #8676
Benjozork
merged 21 commits into
flybywiresim:master
from
Benjozork:refactor/move-to-navigraph-sdk
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # fbw-common/src/systems/instruments/src/EFB/Apis/Navigraph/Components/Authentication.tsx # fbw-common/src/systems/instruments/src/EFB/Efb.tsx # fbw-common/src/systems/instruments/src/EFB/Navigation/Navigation.tsx # fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/LocalFilesPage/LocalFileChartUI.tsx # fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/NavigraphPage/NavigraphChartSelector.tsx # fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/NavigraphPage/NavigraphChartUI.tsx # fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/PinnedChartsPage.tsx # fbw-common/src/systems/instruments/src/EFB/Settings/Pages/ThirdPartyOptionsPage.tsx # fbw-common/src/systems/instruments/src/EFB/Store/features/navigationPage.ts # fbw-common/src/systems/shared/src/navigraph/types.ts
Benjozork
changed the title
refactor: move to official navigraph SDK for charts
refactor: move to official navigraph SDK for charts and authentication
Jun 15, 2024
tracernz
reviewed
Jun 15, 2024
fbw-common/src/systems/instruments/src/EFB/Apis/Navigraph/Components/Authentication.tsx
Outdated
Show resolved
Hide resolved
tracernz
approved these changes
Jun 15, 2024
2hwk
previously requested changes
Jun 15, 2024
...on/src/systems/instruments/src/EFB/Navigation/Pages/NavigraphPage/NavigraphChartSelector.tsx
Show resolved
Hide resolved
fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/LocalFilesPage/LocalFileChartUI.tsx
Show resolved
Hide resolved
12 tasks
Quality Assurance Report Discord: Saschl Testing Process:
Negatives: Upon first load, SimBrief auto-import does not seem to work. When switching pages and returning to the OFP page, the import gets triggered: Testing Results: Conclusions: |
Fixes simbrief auto import as auth data does not seem to be available on the first render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some authentication issues with Navigraph by moving to their official SDK.
Summary of Changes
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.