Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move to official navigraph SDK for charts and authentication #8676

Merged

Conversation

Benjozork
Copy link
Member

@Benjozork Benjozork commented Jun 15, 2024

This fixes some authentication issues with Navigraph by moving to their official SDK.

Summary of Changes

  • Move to official Navigraph SDK
  • Fix chart name being inaccurate

Testing instructions

  • Make sure SImBrief import (both with logged-in Navigraph account and override SimBrief ID) still works correctly
  • Make sure Charts functionality still works correctly (both Navigraph and Local Files)
  • Make sure Navigraph account linking/unlinking works correctly

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

# Conflicts:
#	fbw-common/src/systems/instruments/src/EFB/Apis/Navigraph/Components/Authentication.tsx
#	fbw-common/src/systems/instruments/src/EFB/Efb.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Navigation.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/LocalFilesPage/LocalFileChartUI.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/NavigraphPage/NavigraphChartSelector.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/NavigraphPage/NavigraphChartUI.tsx
#	fbw-common/src/systems/instruments/src/EFB/Navigation/Pages/PinnedChartsPage.tsx
#	fbw-common/src/systems/instruments/src/EFB/Settings/Pages/ThirdPartyOptionsPage.tsx
#	fbw-common/src/systems/instruments/src/EFB/Store/features/navigationPage.ts
#	fbw-common/src/systems/shared/src/navigraph/types.ts
@Benjozork Benjozork changed the title refactor: move to official navigraph SDK for charts refactor: move to official navigraph SDK for charts and authentication Jun 15, 2024
@Saschl
Copy link
Contributor

Saschl commented Jun 16, 2024

Quality Assurance Report

Discord: Saschl
Object of testing: #8676
Tier of Testing : 1
Date: 16/6/2024

Testing Process:

  1. Without unlinking and relinking:

    • Turn on EFB and import simbrief flight plan.
    • Override Simbrief username with a different one than mine and load flight plan again.
    • Opened and searched for different charts.
  2. Performed Unlink and Relink successfuly.

  • Performed same tests as above with success.

Negatives:
Minor finding (Solved now):

Upon first load, SimBrief auto-import does not seem to work. When switching pages and returning to the OFP page, the import gets triggered:

image

Testing Results:
Passed

Conclusions:
LGTM

Saschl and others added 2 commits June 17, 2024 16:21
Fixes simbrief auto import as auth data does not seem to be available on the first render
@Benjozork Benjozork merged commit 958f635 into flybywiresim:master Jun 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants