chore(a380): add a380 fire protection ECAM messages ATA26 #8772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjuhe
changed the title
|
setting this to "do not merge", as long as it's targeted against master and the ECAM PR isn't merged yet :) |
2hwk
approved these changes
Jul 28, 2024
|
Sorry this should've been in draft as I'm still working on adding the PseudoFWC logic to it and the remaining procedures. |
…ire-protection-ecam-messages
flogross89
reviewed
Aug 12, 2024
| }, | ||
| { | ||
| // When timer elapsed, this should change to 'AS STILL FIRE AFTER 30 S' | ||
| name: '.IF STILL FIRE AFTER 30 S :', |
There was a problem hiding this comment.
We don't need a dot in front of the condition on the A380. Also valid for all the other conditions, should be fixed with a search & replace on ".IF"
There was a problem hiding this comment.
Ah cool, makes it simpler, fixed now! Thanks.
| this.emergencyGeneratorOn.get() || | ||
| (this.engine1State.get() === 0 && this.engine2State.get() === 0) || | ||
| (this.greenLP.get() && this.yellowLP.get()) || | ||
| (this.yellowLP.get() && this.blueLP.get()) || | ||
| (this.greenLP.get() && this.blueLP.get())), | ||
| ); | ||
|
|
||
| // Is this needed? |
There was a problem hiding this comment.
Good question, don't know why it was needed on the A32NX in the first place. I'd propose we keep it there and if it causes any trouble we can remove it
There was a problem hiding this comment.
Sounds good and agreed, I've removed the comment.
flogross89
approved these changes
Aug 13, 2024
flogross89
merged commit fa1c4ba
into
flybywiresim:feat-a380x-ecam-update
6 checks passed
flogross89
added a commit
that referenced
this pull request
Sep 19, 2024
* add PseudoFWC from a32nx * use a32nx fwc for ECAM * a380x adaptions * start division * enable formatting * abnormal procedures interface version 1 * format version 2 * update for ATA 22&23 * add ATA 22 ABN * ATA 23 ABN proc items * update PseudoFWC, add TO/LDG memos * add PFD memos * [ECAM] PFD MEMO fix (cherry picked from commit 99bec8c) * XML buttons update * remove right side failures * lint * prep to split between MEMOs and alerts * update FMS switching XML, sounds * update FWC: Connect FMS & RMP failures, introduce structure for abnormal sensed procedures * fix master warnings/cautions * add INFOs, some more ECAM condition check preparation (INOP SYS, INFO) * add STS page with INFO and INOP SYS * ATA 34 MEMOs, some ABNs * chore(a380x): Update Memos of ATA 24, 29 & 32 to reflect A380 (#8741) * Update ATA32 ECAM memos * remove BRK FAN & Ata32 ecam abnormals * add hydraulc & elec memos * Update missing / in Nose wheel steering messages * update ids with new convention * add ATA 24 abnormals * add missing items & inop systems of ATA 24 abnormals * add hyd 29 ecam abnormals * finish ATA 29 abnormal items * hookup logic of elec, hyd & brakes memos * update N/W steer disc id on pfd memo * rebase conflicts minor fix * chore(a380x): add 380 ECAM memos for ATA 27, 28, 31, 33, and 70, and add remaining abnormal sensed procedures (#8749) * Add 380 ECAM memos for ATA 27, 28, 31, 33, and 70 * Add ATA 21 abnormal sensed procedures * fix spacing * Add all remaining ATA 21 ECAM alerts (TODO: checklist items) * Start adding ATA 27 abnormal procedures * Add flap/slat ecam alerts * Add fuel ecam alerts * Fix fuel ecam alerts and add an ATA 33 alert * Add ATA 31 abn proc * Add engine abn proc's * Start adding some checklist items --------- Co-authored-by: Florian Gross <63071941+flogross89@users.noreply.github.com> * split up ABN into multiple files * clean up * fix NO MOBILE sign * add T.O config cautions/warnings * debug line on EWD for abnormals * TO config fixes * overspeed warnings * add third RA; add RA faults * change ATA 32 inop sys * chore(a380x): add ATA 32 abnormal sensed items (#8779) add ata 32 sensed abnormals & inop sys Co-authored-by: flogross89 <63071941+flogross89@users.noreply.github.com> * ATA 34: ADR faults, EXTREME LATITUDE * add LIMITATIONS to PseudoFWC, PFD and SD * rename LIMITATIONS SimVars * fix(gpws/ewd): A380x Flap 3 selection check (#8796) fix too low flaps & ecam ldg flap with config 3 * update sounds, introduce indexed simvars * move FWS to own directory * add IR FAULT, IR IN ALIGN (excess motion) * only unique keys for INFO, INOP SYS, LIMITATION * add normal procedures / ECL definitions * refactor PseudoFWC into multiple files * move EcamMessages * re-introduce abnormal debug line at bottom of WD * update N1 more often in EWD * add C/L button to FWS * change attribute 'color' to 'style', and change to enum * ECL, first version * ECL navigation * chore(a380): add a380 fire protection ECAM messages ATA26 (#8772) * chore: fire detection abnormals * feat: pseudofwc logic for fire abnormals * feat: add limitations * feat: cargo abnormals pt1 * feat: smoke abnormals pt2 * feat: smoke limitations * feat: smoke info * fix: merge conflicts and bring back pseudofwc logic * fix: review comments * ECL progress * fix some errors * finish ECL, first iteration * chore(a380): Add surveillance memos (#8775) * add surv memos * add surv memos logic * update alt reporting off memo logic * update with new structure * fix chopped off MEMOs and LIMITATIONs * fix EGT gauge amber marker * MEMOs for ATA chapters 35, 46 * ECL: remove colon for some items * ABN sensed procedures iteration 1 * refactor checklists, reduce boilerplate * update ECL * abnormals improvement * update font: checked boxes, underscore, quote single/double * use new font, fix ECAM CP * FMS/FUEL&LOAD fix FOB visibility * FMS: use placeholder from font * use LGCIU for gear downlocked * add anti ice MEMOs * update refueling memo * chore(a380x): Finish adding checklist items and pseudoFWC logic for ATA 21, 27, 28, 31, 33, and 70 abnormal procedures (#8773) * Add abnormal checklist for pack 1+2 fault * Add some more abn proc's * Add all abn proc's for ventilation * Start adding cond abn items * finish last of ATA 21 abn proc's * feat(a380/fws): A380 flight phases (#8875) * change flightphase check to enum, check for 4 engines running * update eng takeoff power conditions * fix formatting * fix takeoff power setting condition * hookup RA3, add extra phases to enum * rename vars and add new phases * use 3 RA for ldg memo * change ecam conditions with new flight phases * fix V1 speed check * update takeoff memo & ldg memo flight phases * disable autobrake off memo, fix phase 4 & 5 being active * update fws phase where used in EWD * update checklists flight phases * update phases in fly by wire interface, toconf check & missing fws core * fix ECAM TO abnormals after ENG start * modify sounds for master warn/caution * AUTO SD page * feat(A380): HYD sensed ecam procedures (#8801) * hook up G, Y & G+Y SYS LO PRESS * hookup PMP A+B OFF & missing items in G+Y LO PRESS * fix rebase conflicts * add sys ovht, rsvr level lo & low air pressure ecams * add engine pump vars * hookup vars of pump lo pressure * improve logic of pump fault signal * use section pressure switch vars instead of hydraulic pressure * fix wrong engine running conditions check * fix vars not being properly read * fix conflicts * add eng pump faults, fix pmp A + B off logic * inhibit Y PMP A + B off message if RSV lo pressure * fix var names & add identiation in RSV LO AIR PRESS * add ELEC HYD PMP fault messages * fix elec pmp simvars, add confirmation timer to low press signal * add power source checks to elec pump fault * fix var typos in fws logic & wrong data type in ecam limitations * md lint * chore: add NOMINMAX to fbw, revert clang-format change for fbw (#8925) * feat(a380/mfd): add automatic perf page switching depending on fms phase (#8907) * feat(mfd): add automatic perf switching based on phase * only change active perf page when the phase is the same as the selected page * fix(BTV): Fix crash when BTV exit after runway end (#8874) Fix crash when exit is beyond 300m before runway end * fix(a380x): Various fixes pt.2: MFD, pitch trim switch, EFIS sync for LS button (#8926) * check for valid xpdr code in MFD SURV * fix ILS back course on POSITION/NAVAID * systems-host: enable lint (no functional changes) * disable back course * fix deselect navaid * add PITCH TRIM switch * fix LS EFIS sync * remove debug messages * Revert "systems-host: enable lint (no functional changes)" This reverts commit bc1258d. * Update fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/POSITION/MfdFmsPositionNavaids.tsx Co-authored-by: Michael Corcoran <tracer@outlook.co.nz> * don't use min/max for squawk code * pass only positive courses to MMR --------- Co-authored-by: Michael Corcoran <tracer@outlook.co.nz> * fix link * INOP sys update --------- Co-authored-by: BravoMike99 <119708186+BravoMike99@users.noreply.github.com> Co-authored-by: Sai Sudarshan Barath <69996778+sai-barath@users.noreply.github.com> Co-authored-by: Miquel Juhe <60938089+mjuhe@users.noreply.github.com> Co-authored-by: lukecologne <lukasmichels00@gmail.com> Co-authored-by: Croc <38904654+crocket63@users.noreply.github.com> Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to #8739
Based on #8750
Summary of Changes
Adds abnormal checklists, inop systems, memos and Pseudo FWC logic for the fire protection system. This PR is based on #8750 so it needs to be merged into that or rebased on master.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): Commander Ga
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.