Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/mfd): MFD/FMS based on avionics framework and fms-v2, with VNAV #8510

Merged
merged 1,146 commits into from
Aug 17, 2024

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Feb 18, 2024

Summary of Changes

This PR adds the MFD including FMS functionality. Details to follow.

Fixes #8721
Depends on #7692 and #8493
Predecessor was #8331 (branch without VNAV)

image

Notes on behavior:

  1. Use TOGA for take-off. Don't use FLEX for T/O right now. For temperatures above a threshold, N1 doesn't go high enough to trigger a flight phase change into T/O, which doesn't start the waypoint sequencing.

Influence on other systems:

  • dummy placeholder for VD (vertical display) introduced to fill blank spot in ND; to be removed once Sven's PR is finished&merged
  • deletes fmgc from fbw-a380x
  • PFD speeds: Provides characteristic speeds (GD, F, S) and alpha_prot, alpha_max, alpha_sw to the PFD

Notes for reviewers
EfisSymbols.ts: Removes debug output, console is spammed otherwise
fbw-a380x/fmgc: Deleted, only a32nx/fmgc is referenced. To be move to fbw-common soon
ATCCOM: Moved, will stay in React for now and added as a separate htmlgauge for the MFDs after this PR
MFD/FMC: Contains the FMC system implementation. communication between FMCs and MFDs not yet via SimVars, but FMCs are instantiated from the MFD at the moment (sync and separate FMC/MFD reserved for later, for that the FMCs need to go into systems-host, and communication has to happen via other means)

MFD: Only currently viewed page is kept in memory, once the page is left it's destroyed (and all subscriptions are destroyed as well, important)
Each page usually has their own .tsx and .scss file, commonly used widgets are in /common
FmsPage.tsx provides the basis for all FMS pages.

ND: Changes mostly ported from a32nx after fms-v2 introduction
PFD: Speeds drop-in is a modification to allow displaying the S, F, GD, VLS, alpha p/m speeds from the FMS calculation

Screenshots (if necessary)

References

A380 FCOM, youtube videos

Reference for new ECAMFontNumericalValues (strike through 0):
image

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

Testing also necessary for the A32NX, since some common code parts were changed.
The behavior should not have changed on the A32NX, so please perform a standard flight with full MCDU input. Especially pay attention to the EFIS control panel, route and marker display on ND, as well as flight plan predictions working as expected. Thanks!
But testing this, you will contribute greatly to the release progress of the A380X :)

@flogross89 flogross89 changed the title Feat fmsv2 a380 vnav feat(a380x/mfd): MFD/FMS based on avionics framework and fms-v2, with VNAV Feb 18, 2024
@flogross89 flogross89 added Do Not Merge QA A380 Only QA only for A380 required labels Feb 18, 2024
# Conflicts:
#	fbw-a380x/mach.config.js
#	fbw-a380x/src/systems/instruments/src/MsfsAvionicsCommon/definitions.scss
Copy link
Member

@BlueberryKing BlueberryKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tylerclt
Copy link

Quality Assurance Trainee Report

Discord: Tylerb780#3594
Object of testing: #8510
Tier of Testing: 2
Date: (08/10/2022)

Testing Process:

  1. Loaded into KBOS for a short flight to KALB
  2. Completed preflight as usual, noticed no abnormalities
  3. Departed, no issues noted on taxi out or takeoff
  4. In the climb out there were no issues with the EFIS, ND, or Flight Predictions
  5. During cruise: no issues with the EFIS, ND, or Flight Predictions
  6. Same during descent through final.
    Negatives:
    N/A

Testing Results:
Passed

Conclusions:
Works as intended!

@flogross89 flogross89 removed Needs Code Review QA A380 Only QA only for A380 required labels Aug 14, 2024
@tylerclt
Copy link

Quality Assurance Trainee Report

Discord: tylerb780#3594
Object of testing: #8510
Tier of Testing: 2
Date: 08/15/2024

Testing Process:
Followed testing instructions.

Negatives:
Since I conducted this flight on VATSIM utilizing ATC and hoppie ACARS I did notice when I went back to review my PDC in the MCDU that the page displayed blank when I clicked on the DEPART REQUEST in the MSG record. Other than that no issues. Will attach the image below.

Testing Results:
Failed.

Conclusions:
No issues on EFIS, ND, or route Markers.

Media:
1250410_20240815102926_1

@mattking247
Copy link

Quality Assurance Trainee Report

Discord: Matt
Object of testing: 8510
Tier of Testing: 2
Date: 08/15/2024

Testing Process:
Full flight KMSP - KFAT. Flown offline, so CPDLC issue not tested.

Negatives: Mostly worked according to expectations. Noticed GPU was available on the overhead before selecting GPU on the EFB. displays worked as advertised. TOGA selected for take off and noted at 89%, which seemed low.

Testing Results:
Passed for displays.

Conclusions:
No issues on EFIS, ND, or route Markers. Take off flown in TOGA and no issues switching to the route waypoints.

@Letreivchen
Copy link

Letreivchen commented Aug 17, 2024

Quality Assurance Tester Report

Discord : Letreiv
Object of testing: #8510
Tier of Testing : 2
Date : 17/8/2024

Testing Process:
Full flight from C/D plus missed approach and diversion
Checked functionality of all buttons/switches on the EFIS control panel
Checked instruments and FMGC functionality throughout the flight

Negatives:
None

Testing Results:
Passed

Conclusions:
EDITED: No regression found
Previous mentioned VNAV issue working as intended, no predictions in the go around phase

Media:
none

@flogross89 flogross89 merged commit 82739a0 into flybywiresim:master Aug 17, 2024
7 checks passed
@flogross89 flogross89 deleted the feat-fmsv2-a380-vnav branch August 22, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA Passed
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

[A380X] PFD: Characteristic speeds quick fix