-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a380x/mfd): MFD/FMS based on avionics framework and fms-v2, with VNAV #8510
feat(a380x/mfd): MFD/FMS based on avionics framework and fms-v2, with VNAV #8510
Conversation
# Conflicts: # fbw-a380x/mach.config.js # fbw-a380x/src/systems/instruments/src/MsfsAvionicsCommon/definitions.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Assurance Trainee Report Discord: Tylerb780#3594 Testing Process:
Testing Results: Conclusions: |
Quality Assurance Trainee Report Discord: tylerb780#3594 Testing Process: Negatives: Testing Results: Conclusions: |
Quality Assurance Trainee Report Discord: Matt Testing Process: Negatives: Mostly worked according to expectations. Noticed GPU was available on the overhead before selecting GPU on the EFB. displays worked as advertised. TOGA selected for take off and noted at 89%, which seemed low. Testing Results: Conclusions: |
Quality Assurance Tester Report Discord : Letreiv Testing Process: Negatives: Testing Results: Conclusions: Media: |
Summary of Changes
This PR adds the MFD including FMS functionality. Details to follow.
Fixes #8721
Depends on #7692 and #8493
Predecessor was #8331 (branch without VNAV)
Notes on behavior:
Influence on other systems:
Notes for reviewers
EfisSymbols.ts: Removes debug output, console is spammed otherwise
fbw-a380x/fmgc: Deleted, only a32nx/fmgc is referenced. To be move to fbw-common soon
ATCCOM: Moved, will stay in React for now and added as a separate htmlgauge for the MFDs after this PR
MFD/FMC: Contains the FMC system implementation. communication between FMCs and MFDs not yet via SimVars, but FMCs are instantiated from the MFD at the moment (sync and separate FMC/MFD reserved for later, for that the FMCs need to go into systems-host, and communication has to happen via other means)
MFD: Only currently viewed page is kept in memory, once the page is left it's destroyed (and all subscriptions are destroyed as well, important)
Each page usually has their own .tsx and .scss file, commonly used widgets are in /common
FmsPage.tsx provides the basis for all FMS pages.
ND: Changes mostly ported from a32nx after fms-v2 introduction
PFD: Speeds drop-in is a modification to allow displaying the S, F, GD, VLS, alpha p/m speeds from the FMS calculation
Screenshots (if necessary)
References
A380 FCOM, youtube videos
Reference for new ECAMFontNumericalValues (strike through 0):
Additional context
Discord username (if different from GitHub): floridude
Testing instructions
Testing also necessary for the A32NX, since some common code parts were changed.
The behavior should not have changed on the A32NX, so please perform a standard flight with full MCDU input. Especially pay attention to the EFIS control panel, route and marker display on ND, as well as flight plan predictions working as expected. Thanks!
But testing this, you will contribute greatly to the release progress of the A380X :)