Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library panics when input contains unkown admontion type #35

Open
getreu opened this issue Oct 24, 2021 · 1 comment
Open

library panics when input contains unkown admontion type #35

getreu opened this issue Oct 24, 2021 · 1 comment

Comments

@getreu
Copy link

getreu commented Oct 24, 2021 •
edited
Loading

Consider the following rst input:

hello

.. DANGER::
   Beware killer rabbits!

My thread panics because rust-rst panics.

thread '<unnamed>' panicked at 'Unknown admontion type DANGER!', /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/rst_parser-0.4.0/src/conversion/block.rs:189:24

Expected behaviour

Either silently ignore unknown admontions or return an error type.
@getreu
Copy link
Author

getreu commented Dec 28, 2023

I also experienced some panics on some not implemented language features. A parser library should never panic, but return an error instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@getreu