This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Add LockedUntil column #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no guarantee that the `finished` variable will get set by the goroutine before it is checked in the test, so wait for a channel close instead. Signed-off-by: Lewis Marshall <lewis@lmars.net>
|
@titanous updated to use the time from the server, plus some test fixes. |
| go func() { | ||
| for { | ||
| stat := c.pool.Stat() | ||
| if stat.AvailableConnections == 0 { |
There was a problem hiding this comment.
if c.pool.Stat().AvailableConnections == 0If a job's connection dies, then the advisory lock will be released and another worker can lock the job and start working it, leading to a situation where multiple workers could be working the same job. This change minimises that risk by adding a locked_until column which is bumped in a goroutine whilst a job is being worked, so even if the advisory lock goes away, the job can remain locked until it is done. Signed-off-by: Lewis Marshall <lewis@lmars.net>
|
@titanous comments addressed |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a job's connection dies, then the advisory lock will be released and another worker can lock the job and start working it, leading to a situation where multiple workers could be working the same job.
This change minimises that risk by adding a
locked_untilcolumn which is bumped in a goroutine whilst a job is being worked, so even if the advisory lock goes away, the job can remain locked until it is done.