This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Do not run container as root #patch #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 67.02% 67.02%
=======================================
Files 28 28
Lines 1034 1034
=======================================
Hits 693 693
Misses 282 282
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Fredrik Sannholm <fredrik.sannholm@wolt.com>
Signed-off-by: Fredrik Sannholm <fredrik.sannholm@wolt.com>
frsann
force-pushed
the
docker-non-root
branch
from
ed84f3b
to
7acbd3c
Compare
EngHabu
approved these changes
Oct 22, 2021
|
Congrats on merging your first pull request! 🎉 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Do not run container as root Signed-off-by: Fredrik Sannholm <fredrik.sannholm@wolt.com> * Fix command Signed-off-by: Fredrik Sannholm <fredrik.sannholm@wolt.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes the Docker container not to run as root.
Type
Are all requirements met?
Complete description
The change is made in the Dockerfile, where we create a new group and user to use for running the command.
Tracking Issue
flyteorg/flyte#1606
Follow-up issue