Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Bump go version to 1.19 #90

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Bump go version to 1.19 #90

merged 2 commits into from
Feb 7, 2023

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Feb 6, 2023

TL;DR

Bumping the go version to 1.19 to fix pull request checks.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Daniel Rammer <daniel@union.ai>
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #90 (4c5f293) into master (8a0429f) will decrease coverage by 1.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   69.54%   68.50%   -1.05%     
==========================================
  Files          31       31              
  Lines        1376     1667     +291     
==========================================
+ Hits          957     1142     +185     
- Misses        341      447     +106     
  Partials       78       78              
Flag Coverage Δ
unittests 68.50% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/manager/impl/artifact_data_store.go 60.00% <0.00%> (-8.00%) ⬇️
pkg/repositories/transformers/util.go 76.92% <0.00%> (-3.08%) ⬇️
pkg/repositories/gormimpl/list.go 65.38% <0.00%> (-3.04%) ⬇️
pkg/repositories/transformers/dataset.go 87.50% <0.00%> (-2.98%) ⬇️
pkg/manager/impl/reservation_manager.go 78.46% <0.00%> (-2.85%) ⬇️
pkg/repositories/gormimpl/reservation.go 83.33% <0.00%> (-2.64%) ⬇️
pkg/repositories/transformers/reservation.go 90.00% <0.00%> (-2.60%) ⬇️
pkg/config/config_flags.go 27.58% <0.00%> (-2.05%) ⬇️
pkg/runtime/configs/datacatalogconfig_flags.go 27.58% <0.00%> (-2.05%) ⬇️
pkg/manager/impl/dataset_manager.go 66.66% <0.00%> (-2.03%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Daniel Rammer <daniel@union.ai>
@hamersaw hamersaw merged commit b526b0c into master Feb 7, 2023
@hamersaw hamersaw deleted the housekeeping/bump-go-version branch February 7, 2023 19:30
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* bump go version to 1.19

Signed-off-by: Daniel Rammer <daniel@union.ai>

* bumped flyteidl and flytestdlib

Signed-off-by: Daniel Rammer <daniel@union.ai>

---------

Signed-off-by: Daniel Rammer <daniel@union.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants