Skip to content

Commit

Permalink
Identifier descriptions (#20)
Browse files Browse the repository at this point in the history
* Add optional description field for NamedEntityIdentifier

Adding endpoints for metadata, updating dependencies

Updating protoc image

Changing metadata update request to parse the body into the metadata field

Moving metadata out of NamedEntityIdentifier and using composition instead

Re-thinking how named entities work

* Fixing generation
  • Loading branch information
schottra committed Oct 29, 2019
1 parent da7a050 commit f790c95
Show file tree
Hide file tree
Showing 48 changed files with 21,080 additions and 3,613 deletions.
2 changes: 1 addition & 1 deletion flyteidl/Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions flyteidl/Makefile
Expand Up @@ -9,7 +9,7 @@ update_boilerplate:

.PHONY: generate
generate: # generate protos, mocks and pflags
dep ensure --vendor-only
dep ensure -vendor-only
./generate_protos.sh
./generate_mocks.sh
go generate ./...
Expand All @@ -19,7 +19,7 @@ test: # ensures generate_protos script has been run
make install
git diff
go get github.com/lyft/flytestdlib/cli/pflags
dep ensure --vendor-only
dep ensure -vendor-only
./generate_mocks.sh
go generate ./...
DELTA_CHECK=true ./generate_protos.sh
Expand Down
144 changes: 144 additions & 0 deletions flyteidl/clients/go/admin/mocks/AdminServiceClient.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f790c95

Please sign in to comment.