Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better document the local testing story #20

Closed
georgesnelling opened this issue Nov 19, 2019 · 0 comments
Closed

Better document the local testing story #20

georgesnelling opened this issue Nov 19, 2019 · 0 comments
Assignees
@wild-endeavor
Labels
pri2

Comments

@georgesnelling
Copy link
Contributor

The local testing story is weak... we can do a better job documenting tips for how to improve.

Our initial idea is that the pyflyte execute command can be run locally, but this has some problems like it uses an autodeleting temp dir and it might mess up real outputs in S3, etc.

We'll play around with stuff and at least come up with some short term workarounds.
@EngHabu EngHabu mentioned this issue Jun 10, 2020
Closed
@EngHabu EngHabu closed this as completed Jan 29, 2021
eapolinario referenced this issue in eapolinario/flyte Dec 6, 2022
@schottra
Identifier descriptions (#20)
4d2184d 
* Add optional description field for NamedEntityIdentifier

Adding endpoints for metadata, updating dependencies

Updating protoc image

Changing metadata update request to parse the body into the metadata field

Moving metadata out of NamedEntityIdentifier and using composition instead

Re-thinking how named entities work

* Fixing generation
eapolinario referenced this issue in eapolinario/flyte Dec 6, 2022
@schottra
Adds endpoints for NamedEntities (#20)
0134a1b 
* Adding endpoints for named entities

part of the wiring for new endpoints/manager

Getting most of the plumbing implemented

Getting the GET code path to work

Implementing update

Adding tests for metadata

Refactoring to support listing named entities

Making the endpoints work correctly

Fixing tests

* Remove unused mock field

* Fixing lint errors

* Updating GET endpoint to 404 if passed an invalid project/domain/name

* Fixing lint error

* PR feedback

* Updating package lock

* Removing stub implementation

* Fixing test

* remove misleading comment

* PR feedback and tests

* Adding integration tests and fixing a bug with getting single entities

* fixing a test

* Fixing lockfile

* Relaxing idl constraint

* Fixing lockfile again

* Changing serve command to use local config file again

* PR feedback
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
@EngHabu
Call onChange on first config load (#20)
b3fb6d1 
* Call onChange on first config load

* Ensure we have a repro in unit test & lint
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
@honnix @chanadian
grpc server reflection flag (#20)
5c2bc39 
* grpc server reflection flag

* goimports

* Update Makefile
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@EngHabu
Call onChange on first config load (#20)
e03f2b7 
* Call onChange on first config load

* Ensure we have a repro in unit test & lint
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@schottra
Adds endpoints for NamedEntities (#20)
d2c8b4f 
* Adding endpoints for named entities

part of the wiring for new endpoints/manager

Getting most of the plumbing implemented

Getting the GET code path to work

Implementing update

Adding tests for metadata

Refactoring to support listing named entities

Making the endpoints work correctly

Fixing tests

* Remove unused mock field

* Fixing lint errors

* Updating GET endpoint to 404 if passed an invalid project/domain/name

* Fixing lint error

* PR feedback

* Updating package lock

* Removing stub implementation

* Fixing test

* remove misleading comment

* PR feedback and tests

* Adding integration tests and fixing a bug with getting single entities

* fixing a test

* Fixing lockfile

* Relaxing idl constraint

* Fixing lockfile again

* Changing serve command to use local config file again

* PR feedback
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@honnix @chanadian
grpc server reflection flag (#20)
d18150e 
* grpc server reflection flag

* goimports

* Update Makefile
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@yindia
Added workflow for updating boilerplate code (#20)
b1cc60a
eapolinario pushed a commit that referenced this issue Sep 8, 2023
@schottra
Identifier descriptions (#20)
f790c95 
* Add optional description field for NamedEntityIdentifier

Adding endpoints for metadata, updating dependencies

Updating protoc image

Changing metadata update request to parse the body into the metadata field

Moving metadata out of NamedEntityIdentifier and using composition instead

Re-thinking how named entities work

* Fixing generation
eapolinario pushed a commit that referenced this issue Sep 12, 2023
@wild-endeavor
Flytekit 0.12.4 (#20)
87814b5
eapolinario pushed a commit that referenced this issue Sep 13, 2023
@schottra @eapolinario
Identifier descriptions (#20)
63da295 
* Add optional description field for NamedEntityIdentifier

Adding endpoints for metadata, updating dependencies

Updating protoc image

Changing metadata update request to parse the body into the metadata field

Moving metadata out of NamedEntityIdentifier and using composition instead

Re-thinking how named entities work

* Fixing generation

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario referenced this issue in eapolinario/flyte Sep 26, 2023
@honnix @chanadian
grpc server reflection flag (#20)
bb9856c 
* grpc server reflection flag

* goimports

* Update Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wild-endeavor wild-endeavor

Labels
pri2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EngHabu @georgesnelling @wild-endeavor