Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish error codes in storage failure metrics #216

Closed
1 of 13 tasks
EngHabu opened this issue Mar 20, 2020 · 1 comment
Closed
1 of 13 tasks

Distinguish error codes in storage failure metrics #216

EngHabu opened this issue Mar 20, 2020 · 1 comment
Assignees
@EngHabu
Labels
enhancement New feature or request
Milestone
0.2.0

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Mar 20, 2020

Motivation: Why do you think this is important?
Storage package publishes Head, Read and Write failures but the metric doesn't distinguish between errors when the file isn't found or when there is a more systemic error (e.g. credentials not found) so they are hard to use to debug/diagnose issues.

Goal: What should the final outcome look like, ideally?
The 3 metrics emitted by the storage package should be tagged with the error code.

Describe alternatives you've considered
N/A

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
N/A

Additional context
N/A

Is this a blocker for you to adopt Flyte
N/A
@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Mar 20, 2020
@EngHabu EngHabu mentioned this issue Mar 20, 2020
Merged
8 tasks
@EngHabu EngHabu self-assigned this Mar 20, 2020
@EngHabu
Copy link
Contributor Author

EngHabu commented Mar 20, 2020

v0.3.3

@EngHabu EngHabu closed this as completed Mar 20, 2020
@kumare3 kumare3 added this to the 0.2.0 milestone Mar 30, 2020
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Mar 30, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@EngHabu
[Compiler] Add execution edges only for top level nodes (flyteorg#216)
754079c 
* Fix branch compiler

* cleanup

* fix tests

* clean up

* lint

* docs

* cleanup

* revert config change

* avoid recompiling subworkflows

* Also limit execution edges from start node

* PR Comments

* revert config.yaml

* Use a smaller test file
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@migueltol22
add support for batchScheduler in Spark Tasks (flyteorg#216)
e7fcac0 
* add support for batchScheduler

Signed-off-by: Miguel <mtoledo@lyft.com>

* upd test

Signed-off-by: Miguel <mtoledo@lyft.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@SandraGH5 @samhita-alla
Update fast_registration.py (flyteorg#213)
28223a7 
* Update fast_registration.py

* update fast registration (flyteorg#216)

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* Modify TOC and add a mechanism to consider RST files  (flyteorg#218)

* update fast registration

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* modified TOC and added a mechanism to consider RST files

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* updated conf.py

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* modified TOC

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* edit fast registration (flyteorg#219)

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* Edit fast_registration.rst (flyteorg#220)

* edit fast registration

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* removed unnecessary RST file

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* Fix conflicts in flyteorg#213 (flyteorg#230)

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* Revert "Fix conflicts in flyteorg#213 (flyteorg#230)" (flyteorg#231)

This reverts commit 525fbbcfb8828ac2e0b6d75d637455bcff1b9d21.

Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@Pianist038801
feat: add version display (flyteorg#216)
eac7069 
Signed-off-by: Pianist038801 <steven@union.ai>

Co-authored-by: Pianist038801 <steven@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@flyte-bot
chore(release): Release 0.28.0 [skip ci]
c55d508 
# [0.28.0](http://github.com/lyft/flyteconsole/compare/v0.27.2...v0.28.0) (2021-09-28)

### Features

* add version display ([flyteorg#216](http://github.com/lyft/flyteconsole/issues/216)) ([eac7069](http://github.com/lyft/flyteconsole/commit/eac7069763651e1b98f63a7ea76e906152eea354))
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@yindia @EngHabu
Added flags for using local images in sandbox (flyteorg#216)
be931d7 
* Added flags for local images in sandbox

Signed-off-by: Yuvraj <code@evalsocket.dev>

* debug

Signed-off-by: Yuvraj <code@evalsocket.dev>

* Added pull policy in sandbox

Signed-off-by: Yuvraj <code@evalsocket.dev>

* fix pflag manually

Signed-off-by: Yuvraj <code@evalsocket.dev>

* more changes

Signed-off-by: Yuvraj <code@evalsocket.dev>

* Allow setting ImagePullPolicy in cmd line (flyteorg#218)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* fix test

Signed-off-by: Yuvraj <code@evalsocket.dev>

* Fix docs for ImagePullPolicy values

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@EngHabu
[Compiler] Add execution edges only for top level nodes (flyteorg#216)
351ab2e 
* Fix branch compiler

* cleanup

* fix tests

* clean up

* lint

* docs

* cleanup

* revert config change

* avoid recompiling subworkflows

* Also limit execution edges from start node

* PR Comments

* revert config.yaml

* Use a smaller test file
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@migueltol22
add support for batchScheduler in Spark Tasks (flyteorg#216)
886c838 
* add support for batchScheduler

Signed-off-by: Miguel <mtoledo@lyft.com>

* upd test

Signed-off-by: Miguel <mtoledo@lyft.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@yindia @EngHabu
Added flags for using local images in sandbox (flyteorg#216)
fe72730 
* Added flags for local images in sandbox

Signed-off-by: Yuvraj <code@evalsocket.dev>

* debug

Signed-off-by: Yuvraj <code@evalsocket.dev>

* Added pull policy in sandbox

Signed-off-by: Yuvraj <code@evalsocket.dev>

* fix pflag manually

Signed-off-by: Yuvraj <code@evalsocket.dev>

* more changes

Signed-off-by: Yuvraj <code@evalsocket.dev>

* Allow setting ImagePullPolicy in cmd line (flyteorg#218)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* fix test

Signed-off-by: Yuvraj <code@evalsocket.dev>

* Fix docs for ImagePullPolicy values

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@yindia @EngHabu @austin362667
Added flags for using local images in sandbox (flyteorg#216)
424063c 
* Added flags for local images in sandbox

Signed-off-by: Yuvraj <code@evalsocket.dev>

* debug

Signed-off-by: Yuvraj <code@evalsocket.dev>

* Added pull policy in sandbox

Signed-off-by: Yuvraj <code@evalsocket.dev>

* fix pflag manually

Signed-off-by: Yuvraj <code@evalsocket.dev>

* more changes

Signed-off-by: Yuvraj <code@evalsocket.dev>

* Allow setting ImagePullPolicy in cmd line (flyteorg#218)

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* fix test

Signed-off-by: Yuvraj <code@evalsocket.dev>

* Fix docs for ImagePullPolicy values

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EngHabu EngHabu

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@EngHabu @kumare3