Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add a failure type label to failure metrics in storage package #60

Merged
merged 4 commits into from
Mar 20, 2020

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Mar 20, 2020

TL;DR

Adds failure type as a tag on head, read and write failures emitted by storage package.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added support in labeled package for adding additional labels on metrics then used that in storage package.

Tracking Issue

flyteorg/flyte#216

Follow-up issue

NA

@codecov-io
Copy link

codecov-io commented Mar 20, 2020

Codecov Report

Merging #60 into master will decrease coverage by 0.56%.
The diff coverage is 50.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   72.11%   71.54%   -0.57%     
==========================================
  Files          56       56              
  Lines        2252     2274      +22     
==========================================
+ Hits         1624     1627       +3     
- Misses        504      522      +18     
- Partials      124      125       +1     
Impacted Files Coverage Δ
contextutils/context.go 81.53% <0.00%> (-6.80%) ⬇️
promutils/labeled/metric_option.go 0.00% <0.00%> (ø)
storage/utils.go 57.69% <33.33%> (-17.31%) ⬇️
promutils/labeled/stopwatch.go 66.66% <50.00%> (-7.53%) ⬇️
promutils/labeled/counter.go 40.74% <57.14%> (-2.74%) ⬇️
storage/stow_store.go 62.79% <69.56%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79f354...86c3c25. Read the comment docs.

storage/utils.go Outdated Show resolved Hide resolved
katrogan
katrogan previously approved these changes Mar 20, 2020
@EngHabu EngHabu merged commit 0e9ca38 into master Mar 20, 2020
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Adds failure type as a tag on head, read and write failures emitted by storage package.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants