Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flyteadmin not resolving execution spec fields #2448

Closed
2 tasks done
katrogan opened this issue May 5, 2022 · 1 comment
Closed
2 tasks done

[BUG] Flyteadmin not resolving execution spec fields #2448

katrogan opened this issue May 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service

Comments

@katrogan
Copy link
Contributor

katrogan commented May 5, 2022

Describe the bug

Execution spec fields like labels, annotations, security ctx and raw output data config can be set at different hierarchical layers starting with the create execution request, then the launch plan, then project level settings and finally global defaults.

Admin behavior incorrectly assumed that if you set any of those spec fields, we read all of them at the place where one was set and didn't do any fallbacks to read the other fields from descending hierarchical layers.

Expected behavior

Setting labels at create execution time shouldn't exclude reading the raw output data config from the launch plan (for example)

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@katrogan katrogan added bug Something isn't working flyteadmin Issue for FlyteAdmin Service labels May 5, 2022
@katrogan katrogan self-assigned this May 5, 2022
@katrogan
Copy link
Contributor Author

katrogan commented May 5, 2022

fixed by #2448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service
Projects
None yet
Development

No branches or pull requests

1 participant