This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Proposal: Keep populating execution config attributes from fallbacks #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
katrogan
requested review from
wild-endeavor,
anandswaminathan,
EngHabu and
kumare3
as code owners
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 61.25% 61.13% -0.12%
==========================================
Files 154 154
Lines 11101 11088 -13
==========================================
- Hits 6800 6779 -21
- Misses 3598 3605 +7
- Partials 703 704 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
EngHabu
previously approved these changes
Apr 22, 2022
Good question, I think it's okay to consider one of iam role or k8s service account being set as treating the entire message be the definitive value. What do you think, is this intuitive? |
EngHabu
approved these changes
May 4, 2022
2 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan katroganGH@gmail.com
TL;DR
Keep populating execution config attributes from fallbacks
The ExecutionConfig object only exists as a collection at the MatchableAttribute layer.
But the specific fields it contains are configurable at the CreateExecutionRequest and LaunchPlan spec levels, individually.
If a user sets one of these fields in the CreateExecutionRequest and LaunchPlan spec we should proceed with fallback for other values. This way if say, SecurityCtx is defined at CreateExecutionRequest but RawOutputMetadataPrefix is in the LaunchPlan, the RawOutputMetadataPrefix should not be set to empty at the end of the resolution.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#2448
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/