Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Enable End2End tests on all repos #324

Closed
4 of 13 tasks
EngHabu opened this issue May 27, 2020 · 0 comments
Closed
4 of 13 tasks

[Feature] Enable End2End tests on all repos #324

EngHabu opened this issue May 27, 2020 · 0 comments
Assignees
@EngHabu
Labels
enhancement New feature or request
Milestone
0.5.0

Comments

@EngHabu
Copy link
Contributor

EngHabu commented May 27, 2020 •
edited
Loading

Motivation: Why do you think this is important?
Any change in all repos (at the very least propeller, admin, datacatalog) should trigger end2end tests in CI use all "current" images from flyte repo and substitute the current repo's image with the one just built in the PR. This ensures we do regression testing (all binaries should be n-1 compatible) as well as invoke somewhat expensive/complex tests that do not need to run regularly on some cadence in production environment.

Goal: What should the final outcome look like, ideally?

  • Any PR should trigger end2end tests to run.
  • Failures should block the PR.
  • Merges to master should also trigger end2end tests
  • It should use the current repo's image + everything else from flyte repo.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • FlytePropeller
  • FlyteAdmin (Control Plane service)
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other
@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels May 27, 2020
This was referenced May 27, 2020
Merged
Merged
EngHabu added a commit that referenced this issue May 27, 2020
@EngHabu
End2End: Increase logs in case of failures (#323)
31c1719 
This PR just adds additional logging for when End2end tests fail to help debug issues.

#324
@wild-endeavor wild-endeavor removed the untriaged This issues has not yet been looked at by the Maintainers label Jun 25, 2020
@EngHabu EngHabu added this to the 0.5.0 milestone Jun 25, 2020
@EngHabu EngHabu mentioned this issue Jun 25, 2020
Merged
3 tasks
@EngHabu EngHabu closed this as completed Jun 25, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@pmahindrakar-oss
Added enableSchedule option on registration and linked missing docs (f…
5a17906 
…lyteorg#324)

* Added enableSchedule option on registration

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Added docs and linked missing docs

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@pmahindrakar-oss
Added enableSchedule option on registration and linked missing docs (f…
02cf19e 
…lyteorg#324)

* Added enableSchedule option on registration

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Added docs and linked missing docs

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@pmahindrakar-oss @austin362667
Added enableSchedule option on registration and linked missing docs (f…
cd55089 
…lyteorg#324)

* Added enableSchedule option on registration

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Added docs and linked missing docs

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
mhotan added a commit to mhotan/flyte that referenced this issue Jun 24, 2024
@mhotan
Enable additional flyte components prometheus metrics (flyteorg#324)
e98031a 
Some flyte components were lacking metrics. clustersyncresources is especially necessary now that new projects are created frequently in serverless. But we should be monitoring all internal services to some extent.

* Update clusterresourcesync to export metrics via httpendpoint
* Update clusterresourcesync deployment with Prometheus scrape annotations, disabled by default
* Update propeller deployment  with Prometheus scrape annotations, disabled by default
* Update webhook deployment  with Prometheus scrape annotations, disabled by default
* Create Webhook HPA, default disabled.

Changes are intended to be forward-compatible, specifically with Prometheus Pod and ServiceMonitor.

towards PE-912
towards PE-846
@mhotan mhotan mentioned this issue Jun 24, 2024
Merged
mhotan added a commit to mhotan/flyte that referenced this issue Jun 24, 2024
@mhotan
Enable additional flyte components prometheus metrics (flyteorg#324)
c7d742b 
Some flyte components were lacking metrics. clustersyncresources is especially necessary now that new projects are created frequently in serverless. But we should be monitoring all internal services to some extent.

* Update clusterresourcesync to export metrics via httpendpoint
* Update clusterresourcesync deployment with Prometheus scrape annotations, disabled by default
* Update propeller deployment  with Prometheus scrape annotations, disabled by default
* Update webhook deployment  with Prometheus scrape annotations, disabled by default
* Create Webhook HPA, default disabled.

Changes are intended to be forward-compatible, specifically with Prometheus Pod and ServiceMonitor.

towards PE-912
towards PE-846

Signed-off-by: Mike Hotan <mike@union.ai>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@pmahindrakar-oss @robert-ulbrich-mercedes-benz
Added enableSchedule option on registration and linked missing docs (f…
2ccec59 
…lyteorg#324)

* Added enableSchedule option on registration

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Added docs and linked missing docs

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
troychiu pushed a commit that referenced this issue Jul 8, 2024
@mhotan
Enable additional flyte components prometheus metrics (#324)
2313fad 
Some flyte components were lacking metrics. clustersyncresources is especially necessary now that new projects are created frequently in serverless. But we should be monitoring all internal services to some extent.

* Update clusterresourcesync to export metrics via httpendpoint
* Update clusterresourcesync deployment with Prometheus scrape annotations, disabled by default
* Update propeller deployment  with Prometheus scrape annotations, disabled by default
* Update webhook deployment  with Prometheus scrape annotations, disabled by default
* Create Webhook HPA, default disabled.

Changes are intended to be forward-compatible, specifically with Prometheus Pod and ServiceMonitor.

towards PE-912
towards PE-846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EngHabu EngHabu

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@EngHabu @wild-endeavor