End2End: Increase logs in case of failures #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
approved these changes
May 27, 2020
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 6, 2022
…rg#323) Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
* update dark style theme Signed-off-by: cosmicBboy <niels.bantilan@gmail.com> * update flytekit version Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
…rg#323) Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
austin362667
pushed a commit
to austin362667/flyte
that referenced
this pull request
May 7, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
troychiu
pushed a commit
that referenced
this pull request
Jul 8, 2024
* Add flyteconsole url to FlyteWorkflow CRD (#5449) * Add `ConsoleURL` to `FlyteWorkflow` CRD Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add `ConsoleURL` to flyteadmin config and write it to CRD Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add ConsoleURL to application_config_provider and DeepCopyInto Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * wip Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * more wip Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix flyteplugins unit tests Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix existing propeller unit tests Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add a few unit tests Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Include FLYTE_EXECUTION_URL iff "link_type" is set in the task template Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove TODOs Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Only include consoleURL if task set the relevant bit in its task template Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix flyteplugins tests Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove attempt number from the url Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Include review feedback Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add mockery/v2 to boilerplate Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Remove TODO Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds additional logging for when End2end tests fail to help debug issues.
#324