Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel/Map Node #40

Closed
georgesnelling opened this issue Nov 19, 2019 · 1 comment
Closed

Parallel/Map Node #40

georgesnelling opened this issue Nov 19, 2019 · 1 comment
Assignees
Labels

Comments

@georgesnelling
Copy link
Contributor

Allow loose parallelism as a native part of the Flyte spec.  In other words, allow a 'parallel node' to take a list of inputs and map the work out to replicas of the same executable: task, workflow, or launch plan.

@EngHabu
Copy link
Contributor

EngHabu commented Jan 29, 2021

Bug bankruptcy.

@EngHabu EngHabu closed this as completed Jan 29, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
* Tagging errors as User or System error

* Update protos/flyteidl/core/execution.proto

Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>

* Update protos/flyteidl/core/execution.proto

Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>

* generated files

Co-authored-by: Haytham AbuelFutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
* Push to master merges to dockerhub

* Create push_docker.yml

* add github_push target

* Add github registry build and push

* Push to dockerhub from github actions

* add workflows to docker ignore

* templetize

* Apply local boilerplate version

* Test failure

* Reapply boilerplate
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
flyteorg#40)

* Fix separator used in UrlPath to '/' instead of OS-dependent path separator

* PR Comments

* lint
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* WIP: add reservation apis

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add missing files

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added create DAO

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Add get dao

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wip

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wired reservation manager

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add todos

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more logging

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add logging and stats

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* First -> Take

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* WIP: add createOrupdate API

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (flyteorg#41)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* update boilerplate code (flyteorg#40)

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Upgrade gorm to v1.21.9 (flyteorg#42)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (flyteorg#43)

Signed-off-by: Yuvraj <evalsocket@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more instructinos

Use upsert

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* refactor a bit

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add timer

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint / tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add comments & tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix connection error handling (flyteorg#45)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Update code of conduct (flyteorg#46)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* separated ReservationManager CreateOrUpdate function into individual Create and Update functions

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed race condition on Reservation repository Create function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint and unit test errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for extending reservation and update failure

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed ExtendReservation API mocks

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented ReleaseReservation

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for reservation transformer

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented unit tests for ReleaseReservation API call

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated reservation API to only work with reservations - not actual artifacts.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix error type check to detect uniqueConstraintViolation

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Revert "Fix error type check to detect uniqueConstraintViolation"

This reverts commit 2ba0775.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix gorm wrong error type cast (flyteorg#48)

* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added support for heartbeat_interval definition in reservation manager

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated test and fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed unnecessary dependencies from go.mod

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version - change before merging

Signed-off-by: Daniel Rammer <daniel@union.ai>

* adding reservation model to migration

Signed-off-by: Daniel Rammer <daniel@union.ai>

* udpated dockerfile go template to reflect current master fixing rebase overwrites

Signed-off-by: Daniel Rammer <daniel@union.ai>

* and again .. with a space

Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs on exports

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed configuration to use config.Duration from flytestdlib instead of defining on seconds

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added owner id to reservation gorm impl delete function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version

Signed-off-by: Daniel Rammer <daniel@union.ai>

* remove flyteidl replace in go.mod and updating to latest version

Signed-off-by: Daniel Rammer <daniel@union.ai>

Co-authored-by: Chao-Han Tsai <milton0825@gmail.com>
Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com>
Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
* Push to master merges to dockerhub

* Create push_docker.yml

* add github_push target

* Add github registry build and push

* Push to dockerhub from github actions

* add workflows to docker ignore

* templetize

* Apply local boilerplate version

* Test failure

* Reapply boilerplate
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
flyteorg#40)

* Fix separator used in UrlPath to '/' instead of OS-dependent path separator

* PR Comments

* lint
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
* WIP: add reservation apis

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add missing files

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added create DAO

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Add get dao

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wip

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wired reservation manager

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add todos

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more logging

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add logging and stats

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* First -> Take

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* WIP: add createOrupdate API

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (flyteorg#41)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* update boilerplate code (flyteorg#40)

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Upgrade gorm to v1.21.9 (flyteorg#42)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (flyteorg#43)

Signed-off-by: Yuvraj <evalsocket@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more instructinos

Use upsert

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* refactor a bit

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add timer

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint / tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add comments & tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix connection error handling (flyteorg#45)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Update code of conduct (flyteorg#46)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* separated ReservationManager CreateOrUpdate function into individual Create and Update functions

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed race condition on Reservation repository Create function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint and unit test errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for extending reservation and update failure

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed ExtendReservation API mocks

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented ReleaseReservation

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for reservation transformer

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented unit tests for ReleaseReservation API call

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated reservation API to only work with reservations - not actual artifacts.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix error type check to detect uniqueConstraintViolation

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Revert "Fix error type check to detect uniqueConstraintViolation"

This reverts commit a237bf0.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix gorm wrong error type cast (flyteorg#48)

* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added support for heartbeat_interval definition in reservation manager

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated test and fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed unnecessary dependencies from go.mod

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version - change before merging

Signed-off-by: Daniel Rammer <daniel@union.ai>

* adding reservation model to migration

Signed-off-by: Daniel Rammer <daniel@union.ai>

* udpated dockerfile go template to reflect current master fixing rebase overwrites

Signed-off-by: Daniel Rammer <daniel@union.ai>

* and again .. with a space

Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs on exports

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed configuration to use config.Duration from flytestdlib instead of defining on seconds

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added owner id to reservation gorm impl delete function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version

Signed-off-by: Daniel Rammer <daniel@union.ai>

* remove flyteidl replace in go.mod and updating to latest version

Signed-off-by: Daniel Rammer <daniel@union.ai>

Co-authored-by: Chao-Han Tsai <milton0825@gmail.com>
Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com>
Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit that referenced this issue Sep 7, 2023
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
eapolinario pushed a commit that referenced this issue Sep 7, 2023
* WIP: add reservation apis

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add missing files

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added create DAO

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Add get dao

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wip

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wired reservation manager

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add todos

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more logging

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add logging and stats

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* First -> Take

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* WIP: add createOrupdate API

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (#41)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* update boilerplate code (#40)

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Upgrade gorm to v1.21.9 (#42)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (#43)

Signed-off-by: Yuvraj <evalsocket@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more instructinos

Use upsert

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* refactor a bit

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add timer

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint / tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add comments & tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix connection error handling (#45)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Update code of conduct (#46)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* separated ReservationManager CreateOrUpdate function into individual Create and Update functions

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed race condition on Reservation repository Create function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint and unit test errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for extending reservation and update failure

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed ExtendReservation API mocks

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented ReleaseReservation

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for reservation transformer

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented unit tests for ReleaseReservation API call

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated reservation API to only work with reservations - not actual artifacts.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix error type check to detect uniqueConstraintViolation

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Revert "Fix error type check to detect uniqueConstraintViolation"

This reverts commit 22c2d03.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix gorm wrong error type cast (#48)

* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added support for heartbeat_interval definition in reservation manager

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated test and fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed unnecessary dependencies from go.mod

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version - change before merging

Signed-off-by: Daniel Rammer <daniel@union.ai>

* adding reservation model to migration

Signed-off-by: Daniel Rammer <daniel@union.ai>

* udpated dockerfile go template to reflect current master fixing rebase overwrites

Signed-off-by: Daniel Rammer <daniel@union.ai>

* and again .. with a space

Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs on exports

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed configuration to use config.Duration from flytestdlib instead of defining on seconds

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added owner id to reservation gorm impl delete function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version

Signed-off-by: Daniel Rammer <daniel@union.ai>

* remove flyteidl replace in go.mod and updating to latest version

Signed-off-by: Daniel Rammer <daniel@union.ai>

Co-authored-by: Chao-Han Tsai <milton0825@gmail.com>
Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com>
Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit that referenced this issue Sep 8, 2023
* Tagging errors as User or System error

* Update protos/flyteidl/core/execution.proto

Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>

* Update protos/flyteidl/core/execution.proto

Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>

* generated files

Co-authored-by: Haytham AbuelFutuh <haytham@afutuh.com>
eapolinario pushed a commit that referenced this issue Sep 12, 2023
* Create README.md

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Add default service account name

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update README.md

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update README.md

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit that referenced this issue Sep 13, 2023
* Tagging errors as User or System error

* Update protos/flyteidl/core/execution.proto

Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>

* Update protos/flyteidl/core/execution.proto

Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>

* generated files

Co-authored-by: Haytham AbuelFutuh <haytham@afutuh.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
pvditt pushed a commit that referenced this issue Dec 29, 2023
* Tagging errors as User or System error

* Update protos/flyteidl/core/execution.proto

Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>

* Update protos/flyteidl/core/execution.proto

Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>

* generated files

Co-authored-by: Haytham AbuelFutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
Signed-off-by: Yuvraj <evalsocket@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
Signed-off-by: Yuvraj <evalsocket@gmail.com>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
Signed-off-by: Yuvraj <evalsocket@gmail.com>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
Signed-off-by: Yuvraj <evalsocket@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants