Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure SDK Error Messages Render Correctly for Entities When Config is Not Set #48

Closed
georgesnelling opened this issue Nov 19, 2019 · 1 comment
Closed

Ensure SDK Error Messages Render Correctly for Entities When Config is Not Set #48

georgesnelling opened this issue Nov 19, 2019 · 1 comment
Assignees
@matthewphsmith
Labels
bug Something isn't working pri3

Comments

@georgesnelling
Copy link
Contributor

Some repr methods in Flytekit SDK rely on "required" configurations. This obscures exceptions when config is not available in the environment.
@georgesnelling georgesnelling added bug Something isn't working pri3 Trust labels Nov 19, 2019
@kumare3
Copy link
Contributor

kumare3 commented Jun 10, 2020

marking this as done, as it is not reproducible

@kumare3 kumare3 closed this as completed Jun 10, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@katrogan
Add identifier context values (flyteorg#48)
84f181a
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@surindersinghp
Adding output-dir for node output for each retry (flyteorg#48)
7b32cbb 
* Fixing data dir for retries

* mock

* fixing tests

* reworked retry attempt. Now we have 2 different paths- one for input and the other for output. New output dir is created for every attempt while input dir remains the same for the complete node execution

* bug fix

* .

* .

* .

* fix

* logging

* missed file

* fixing tests and removing bogus logging

* yet another fix

* fixing the comment

* .

* .

* fix endnode test
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@katrogan
Add system metadata to execution metadata (flyteorg#48)
2ee8973
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@EngHabu
Emit size gauge metric for autorefresh cache (flyteorg#48)
99aa382
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@katrogan
Add demystify success for OOMKilled (flyteorg#48)
93e0b8d
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@EngHabu
Fix gorm wrong error type cast (flyteorg#48)
11d64b3 
* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@hamersaw @milton0825
@yindia @samhita-alla @EngHabu
Cache Serailize API (flyteorg#47)
b1b4f65 
* WIP: add reservation apis

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add missing files

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added create DAO

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Add get dao

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wip

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wired reservation manager

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add todos

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more logging

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add logging and stats

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* First -> Take

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* WIP: add createOrupdate API

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (flyteorg#41)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* update boilerplate code (flyteorg#40)

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Upgrade gorm to v1.21.9 (flyteorg#42)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (flyteorg#43)

Signed-off-by: Yuvraj <evalsocket@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more instructinos

Use upsert

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* refactor a bit

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add timer

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint / tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add comments & tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix connection error handling (flyteorg#45)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Update code of conduct (flyteorg#46)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* separated ReservationManager CreateOrUpdate function into individual Create and Update functions

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed race condition on Reservation repository Create function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint and unit test errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for extending reservation and update failure

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed ExtendReservation API mocks

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented ReleaseReservation

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for reservation transformer

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented unit tests for ReleaseReservation API call

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated reservation API to only work with reservations - not actual artifacts.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix error type check to detect uniqueConstraintViolation

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Revert "Fix error type check to detect uniqueConstraintViolation"

This reverts commit 2ba0775.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix gorm wrong error type cast (flyteorg#48)

* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added support for heartbeat_interval definition in reservation manager

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated test and fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed unnecessary dependencies from go.mod

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version - change before merging

Signed-off-by: Daniel Rammer <daniel@union.ai>

* adding reservation model to migration

Signed-off-by: Daniel Rammer <daniel@union.ai>

* udpated dockerfile go template to reflect current master fixing rebase overwrites

Signed-off-by: Daniel Rammer <daniel@union.ai>

* and again .. with a space

Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs on exports

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed configuration to use config.Duration from flytestdlib instead of defining on seconds

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added owner id to reservation gorm impl delete function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version

Signed-off-by: Daniel Rammer <daniel@union.ai>

* remove flyteidl replace in go.mod and updating to latest version

Signed-off-by: Daniel Rammer <daniel@union.ai>

Co-authored-by: Chao-Han Tsai <milton0825@gmail.com>
Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com>
Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@surindersinghp
Adding output-dir for node output for each retry (flyteorg#48)
78b1164 
* Fixing data dir for retries

* mock

* fixing tests

* reworked retry attempt. Now we have 2 different paths- one for input and the other for output. New output dir is created for every attempt while input dir remains the same for the complete node execution

* bug fix

* .

* .

* .

* fix

* logging

* missed file

* fixing tests and removing bogus logging

* yet another fix

* fixing the comment

* .

* .

* fix endnode test
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Emit size gauge metric for autorefresh cache (flyteorg#48)
66e0317
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Add identifier context values (flyteorg#48)
fd9d762
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Add demystify success for OOMKilled (flyteorg#48)
9da6821
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Fix gorm wrong error type cast (flyteorg#48)
cf145bd 
* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@hamersaw @milton0825
@yindia @samhita-alla @EngHabu
Cache Serailize API (flyteorg#47)
a9d0f7c 
* WIP: add reservation apis

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add missing files

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added create DAO

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Add get dao

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wip

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wired reservation manager

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add todos

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more logging

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add logging and stats

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* First -> Take

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* WIP: add createOrupdate API

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (flyteorg#41)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* update boilerplate code (flyteorg#40)

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Upgrade gorm to v1.21.9 (flyteorg#42)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (flyteorg#43)

Signed-off-by: Yuvraj <evalsocket@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more instructinos

Use upsert

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* refactor a bit

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add timer

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint / tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add comments & tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix connection error handling (flyteorg#45)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Update code of conduct (flyteorg#46)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* separated ReservationManager CreateOrUpdate function into individual Create and Update functions

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed race condition on Reservation repository Create function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint and unit test errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for extending reservation and update failure

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed ExtendReservation API mocks

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented ReleaseReservation

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for reservation transformer

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented unit tests for ReleaseReservation API call

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated reservation API to only work with reservations - not actual artifacts.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix error type check to detect uniqueConstraintViolation

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Revert "Fix error type check to detect uniqueConstraintViolation"

This reverts commit a237bf0.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix gorm wrong error type cast (flyteorg#48)

* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added support for heartbeat_interval definition in reservation manager

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated test and fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed unnecessary dependencies from go.mod

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version - change before merging

Signed-off-by: Daniel Rammer <daniel@union.ai>

* adding reservation model to migration

Signed-off-by: Daniel Rammer <daniel@union.ai>

* udpated dockerfile go template to reflect current master fixing rebase overwrites

Signed-off-by: Daniel Rammer <daniel@union.ai>

* and again .. with a space

Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs on exports

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed configuration to use config.Duration from flytestdlib instead of defining on seconds

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added owner id to reservation gorm impl delete function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version

Signed-off-by: Daniel Rammer <daniel@union.ai>

* remove flyteidl replace in go.mod and updating to latest version

Signed-off-by: Daniel Rammer <daniel@union.ai>

Co-authored-by: Chao-Han Tsai <milton0825@gmail.com>
Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com>
Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@samhita-alla
remove welcome bot (flyteorg#48)
1b1e6e1 
* update perms of code_of_conduct update.sh

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* Remove welcome-bot

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
eapolinario pushed a commit that referenced this issue Sep 7, 2023
@EngHabu
Fix gorm wrong error type cast (#48)
2379b58 
* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit that referenced this issue Sep 7, 2023
@hamersaw @milton0825
@yindia @samhita-alla @EngHabu
Cache Serailize API (#47)
a3a6c7f 
* WIP: add reservation apis

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add missing files

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added create DAO

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Add get dao

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wip

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* wired reservation manager

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add todos

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more logging

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add logging and stats

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* First -> Take

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* WIP: add createOrupdate API

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (#41)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* update boilerplate code (#40)

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Upgrade gorm to v1.21.9 (#42)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Added boilerplate automation (#43)

Signed-off-by: Yuvraj <evalsocket@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more instructinos

Use upsert

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add more comments

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* refactor a bit

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add timer

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint / tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add comments & tests

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* fix lint

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs

Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix connection error handling (#45)

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Update code of conduct (#46)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* separated ReservationManager CreateOrUpdate function into individual Create and Update functions

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed race condition on Reservation repository Create function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed reservation expiration to use heartbeatInterval and heartbeatGracePeriodMultiplier

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint and unit test errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for extending reservation and update failure

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed ExtendReservation API mocks

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added ExpiresAt and HeartbeatInterval fiedls to ReservationStatus return based on new API

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented ReleaseReservation

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests for reservation transformer

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* implemented unit tests for ReleaseReservation API call

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated reservation API to only work with reservations - not actual artifacts.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix error type check to detect uniqueConstraintViolation

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* Revert "Fix error type check to detect uniqueConstraintViolation"

This reverts commit 22c2d03.

Signed-off-by: Daniel Rammer <daniel@union.ai>

* Fix gorm wrong error type cast (#48)

* Fix gorm wrong error type cast

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Fix unit tests

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Support unwrapping errors to detect connection problems

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* cleanup

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>

* added support for heartbeat_interval definition in reservation manager

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated test and fixed lint errors

Signed-off-by: Daniel Rammer <daniel@union.ai>

* removed unnecessary dependencies from go.mod

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version - change before merging

Signed-off-by: Daniel Rammer <daniel@union.ai>

* adding reservation model to migration

Signed-off-by: Daniel Rammer <daniel@union.ai>

* udpated dockerfile go template to reflect current master fixing rebase overwrites

Signed-off-by: Daniel Rammer <daniel@union.ai>

* and again .. with a space

Signed-off-by: Daniel Rammer <daniel@union.ai>

* add docs on exports

Signed-off-by: Daniel Rammer <daniel@union.ai>

* changed configuration to use config.Duration from flytestdlib instead of defining on seconds

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added owner id to reservation gorm impl delete function

Signed-off-by: Daniel Rammer <daniel@union.ai>

* if reservation is missing on release reservation (meaning another entity acquired it) then gracefully fail

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl version

Signed-off-by: Daniel Rammer <daniel@union.ai>

* remove flyteidl replace in go.mod and updating to latest version

Signed-off-by: Daniel Rammer <daniel@union.ai>

Co-authored-by: Chao-Han Tsai <milton0825@gmail.com>
Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com>
Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit that referenced this issue Sep 8, 2023
@katrogan
Add system metadata to execution metadata (#48)
6876b0b
eapolinario pushed a commit that referenced this issue Sep 12, 2023
@yindia
Added e2e test (#48)
1f3d47a 
Signed-off-by: Yuvraj <code@evalsocket.dev>
eapolinario pushed a commit that referenced this issue Sep 13, 2023
@katrogan @eapolinario
Add system metadata to execution metadata (#48)
fb79eed 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
pvditt pushed a commit that referenced this issue Dec 29, 2023
@katrogan
Add system metadata to execution metadata (#48)
b4b76d2
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@yindia
Update template formate in install script (flyteorg#48)
93f3349 
Signed-off-by: yuvraj <evalsocket@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@yindia
Update template formate in install script (flyteorg#48)
e3aaedb 
Signed-off-by: yuvraj <evalsocket@gmail.com>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@yindia @austin362667
Update template formate in install script (flyteorg#48)
94cabe5 
Signed-off-by: yuvraj <evalsocket@gmail.com>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@yindia @robert-ulbrich-mercedes-benz
Update template formate in install script (flyteorg#48)
d200e63 
Signed-off-by: yuvraj <evalsocket@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewphsmith matthewphsmith

Labels
bug Something isn't working pri3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@georgesnelling @matthewphsmith @kumare3