Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] testdata folder is not put together with test cases #502

Closed
1 of 13 tasks
honnix opened this issue Sep 7, 2020 · 0 comments
Closed
1 of 13 tasks

[BUG] testdata folder is not put together with test cases #502

honnix opened this issue Sep 7, 2020 · 0 comments
Assignees
@honnix
Labels
bug Something isn't working

Comments

@honnix
Copy link
Member

honnix commented Sep 7, 2020

Describe the bug
pkg/executioncluster/impl/random_cluster_selector_test.go uses files from testdata which is stored in the parent folder. This is not needed.

Expected behavior
testdata folder sits together with pkg/executioncluster/impl/random_cluster_selector_test.go in the same folder.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
N/A

Screenshots
N/A

Environment
N/A

Additional context
N/A
@honnix honnix added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Sep 7, 2020
@honnix honnix mentioned this issue Sep 7, 2020
Merged
8 tasks
@honnix honnix removed the untriaged This issues has not yet been looked at by the Maintainers label Sep 8, 2020
@honnix honnix self-assigned this Sep 8, 2020
@honnix honnix closed this as completed Sep 8, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@katrogan
Fix typo in launch entity rollback (flyteorg#502)
fce143d 
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>

Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@dependabot
chore(deps-dev): bump protobufjs from 6.8.9 to 6.11.3 (flyteorg#502)
d407301 
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.8.9 to 6.11.3.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md)
- [Commits](https://github.com/protobufjs/protobuf.js/commits/v6.11.3)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Fix typo in launch entity rollback (flyteorg#502)
768e7eb 
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>

Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@honnix honnix

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@honnix