Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add explanation about insecure option #2145

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

yongchand
Copy link
Contributor

Signed-off-by: yongchand <yongchana@gmail.com>
@welcome
Copy link

welcome bot commented Feb 8, 2022

Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line: - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: DCO Guide).

@yindia yindia requested a review from EngHabu February 8, 2022 17:02
@@ -590,7 +590,7 @@ Flyte can be accessed using the UI console or your terminal.
flyte <none> * k8s-flyte-8699360f2e-1590325550.us-east-2.elb.amazonaws.com 80 3m50s
flyte-grpc <none> * k8s-flyte-8699360f2e-1590325550.us-east-2.elb.amazonaws.com 80 3m49s

<FLYTE-ENDPOINT> = Value in ADDRESS column and both will be the same as the same port is used for both GRPC and HTTP.
<FLYTE-ENDPOINT> = Value in ADDRESS column and both will be the same as the same port is used for both GRPC and HTTP. Own host website may work too.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can revert this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

yindia
yindia previously approved these changes Feb 8, 2022
Signed-off-by: yongchand <yongchana@gmail.com>
@yongchand yongchand changed the title fix: add explanation about insecure option and flyte endpoint fix: add explanation about insecure option Feb 8, 2022
@kumare3 kumare3 merged commit 701ef69 into flyteorg:master Feb 8, 2022
@welcome
Copy link

welcome bot commented Feb 8, 2022

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants