Moving from flytepropeller - Adding flags for ignore-retry-cause and default-max-attempts

[eapolinario]

TL;DR

Adding flags to simplify retry behavior. ignore-retry-cause means that system and user failures are treated the same and default-max-attempts sets a default number of retries for tasks.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4ee73f5) 59.44% compared to head (89eaa65) 59.32%.

❗ Current head 89eaa65 differs from pull request most recent head d767dc0. Consider uploading reports for the commit d767dc0 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4153      +/-   ##
==========================================
- Coverage   59.44%   59.32%   -0.13%     
==========================================
  Files         637      550      -87     
  Lines       54262    39710   -14552     
==========================================
- Hits        32254    23556    -8698     
+ Misses      19467    13834    -5633     
+ Partials     2541     2320     -221     

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...go/tasks/plugins/array/k8s/subtask_exec_context.go	83.18% <100.00%> (+1.36%)	⬆️
...tepropeller/pkg/compiler/transformers/k8s/utils.go	87.01% <100.00%> (+0.27%)	⬆️
flytepropeller/pkg/controller/config/config.go	0.00% <ø> (ø)
...ytepropeller/pkg/controller/config/config_flags.go	75.94% <100.00%> (+2.53%)	⬆️
...ytepropeller/pkg/controller/nodes/array/handler.go	70.37% <100.00%> (+1.01%)	⬆️
flytepropeller/pkg/controller/nodes/executor.go	61.61% <100.00%> (+1.21%)	⬆️
...ller/pkg/controller/nodes/task/taskexec_context.go	80.13% <100.00%> (+1.12%)	⬆️
...ropeller/pkg/controller/nodes/node_exec_context.go	84.74% <81.25%> (+2.20%)	⬆️

... and 567 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eapolinario]

LGTM, but I can't approve a PR I opened. 😂