Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify how flytecopilot version is parsed from values file #4496

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

eapolinario
Copy link
Contributor

Describe your changes

In #4304 we modified the way all version were fetched from the values file, however that's not correct in the case of flytecopilot. In this PR we go back to the correct way of fetching the version of flytecopilot from the values file.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 30, 2023
@eapolinario eapolinario merged commit 7c061b8 into master Nov 30, 2023
12 of 23 checks passed
@eapolinario eapolinario deleted the fix-create-release-gh-workflow branch November 30, 2023 01:54
@eapolinario eapolinario mentioned this pull request Nov 30, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant