Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Flyte releases #4304

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Restructure Flyte releases #4304

merged 1 commit into from
Oct 27, 2023

Conversation

eapolinario
Copy link
Contributor

Describe your changes

This PR restructures Flyte releases to happen only manually. We still produce a manifest, but the manifest is going to rely on the fact that at release time the artifacts (images, tags, etc) will be in place. This forces the user who's driving the release needs to be careful to use the same version across the two gh workflows:

  1. generate_flyte_manifest
    i. in other words, generate_flyte_manifest now takes a next-version as input. This version is used to update the helm charts / kustomize.
  2. create_release

Other changes:

  • The checks gh workflow no longer produces tags + docker images on merges to master.
    • These new images are now only created at release time, when we kick off the create_release gh workflow.
  • You'll notice that I didn't change the logic to retag docker images with the suffix -release (used in the prepare_artifacts make target).
    • The main reason behind that was to decrease the number of changes in this PR.
  • I removed the bump-tags gh workflow completely and moved that functionality to create_release.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario merged commit ef31e55 into master Oct 27, 2023
12 checks passed
@eapolinario eapolinario deleted the only-tag-on-releases branch October 27, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants