Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove end2end.yml #5034

Merged
merged 16 commits into from
Jun 16, 2024
Merged

Remove end2end.yml #5034

merged 16 commits into from
Jun 16, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Mar 10, 2024

Tracking issue

NA

What changes were proposed in this pull request?

We already have end2end tests here, so we don't need end2end.yml anymore

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytectl#462

Docs link

Signed-off-by: Kevin Su <pingsutw@gmail.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Mar 10, 2024
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.99%. Comparing base (02bf85f) to head (83eecb5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5034   +/-   ##
=======================================
  Coverage   60.99%   60.99%           
=======================================
  Files         793      793           
  Lines       51350    51350           
=======================================
  Hits        31319    31319           
  Misses      17145    17145           
  Partials     2886     2886           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.70% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.97% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.84% <ø> (ø)
unittests-flytepropeller 57.30% <ø> (ø)
unittests-flytestdlib 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario
Copy link
Contributor

I'm 99% sure we don't use this workflow anywhere. Can you double-check and if that's the case, should we remove it?

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw
Copy link
Member Author

pingsutw commented May 6, 2024

@eapolinario I revive end2end test. It only runs when merging PRs since it takes 15 minutes.

https://github.com/flyteorg/flyte/actions/runs/8967710966/job/24626449666?pr=5034

Signed-off-by: Kevin Su <pingsutw@apache.org>
@click.option(
"--parallel",
is_flag=True,
default=False,
Copy link
Member Author

@pingsutw pingsutw May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run flytesnacks workflow serially by default in the CI due to disk pressure in the sandbox.

Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty cool. Thank you!

.github/workflows/end2end.yml Outdated Show resolved Hide resolved
eapolinario
eapolinario previously approved these changes May 8, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario
eapolinario previously approved these changes May 8, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw
Copy link
Member Author

pingsutw commented May 9, 2024

Just found that we already have end2end tests here, so we don't need end2end.yml anymore

@pingsutw pingsutw changed the title Use flytectl demo to run integration tests Remove end2end.yml May 9, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@eapolinario eapolinario merged commit 59e18d1 into master Jun 16, 2024
50 checks passed
@eapolinario eapolinario deleted the flytectl-demo branch June 16, 2024 01:35
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants