Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Remove sandbox command #462

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove sandbox command #462

wants to merge 5 commits into from

Conversation

pingsutw
Copy link
Member

TL;DR

The sandbox command has already been deprecated for a while; we can remove it now.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c87165) 67.69% compared to head (659723f) 67.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   67.69%   67.66%   -0.03%     
==========================================
  Files         148      143       -5     
  Lines        6639     6575      -64     
==========================================
- Hits         4494     4449      -45     
+ Misses       1855     1841      -14     
+ Partials      290      285       -5     
Flag Coverage Δ
unittests 67.66% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
@pmahindrakar-oss
Copy link
Contributor

@pingsutw We should probably move the references in flyte repo before removing this command from flytectl
https://github.com/search?q=repo%3Aflyteorg%2Fflyte%20%22flytectl%20sandbox%22&type=code

@pingsutw pingsutw mentioned this pull request Mar 10, 2024
3 tasks
@pingsutw
Copy link
Member Author

flyteorg/flyte#5034

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants