Upgrade logrus to v1.9.3 everywhere #5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5139 +/- ##
==========================================
+ Coverage 59.09% 59.11% +0.01%
==========================================
Files 645 645
Lines 55540 55540
==========================================
+ Hits 32824 32831 +7
+ Misses 20127 20120 -7
Partials 2589 2589
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ddl-ebrown
force-pushed
the
upgrade-logrus
branch
4 times, most recently
from
2b148e7
to
49070d5
Compare
- Most flyte binaries are on v1.9.3 but some are still on an older v1.7.0 which contains PRISMA-2023-0056 Run go mod tidy Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com>
ddl-ebrown
force-pushed
the
upgrade-logrus
branch
from
49070d5
to
3e4d7d7
Compare
eapolinario
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
logrus sets off some security scanners with a medium vuln
What changes were proposed in this pull request?
Most flyte binaries are on v1.9.3 but some are still on an older v1.7.0 which contains PRISMA-2023-0056
Also run go mod tidy
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link