Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pin flyteconsole version in release process (#5037)" #5176

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

eapolinario
Copy link
Contributor

This reverts commit 68a3415.

Tracking issue

NA

Why are the changes needed?

Schedules are now implemented in the revamped flyteconsole. Time to revert the pin.

What changes were proposed in this pull request?

Just revert the pin.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

This reverts commit 68a3415.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Apr 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.10%. Comparing base (dc1294e) to head (31597b6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5176      +/-   ##
==========================================
- Coverage   59.11%   59.10%   -0.01%     
==========================================
  Files         645      645              
  Lines       55574    55574              
==========================================
- Hits        32852    32849       -3     
- Misses      20129    20131       +2     
- Partials     2593     2594       +1     
Flag Coverage Δ
unittests 59.10% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) April 3, 2024 20:44
@eapolinario eapolinario merged commit b9dfb01 into master Apr 3, 2024
47 of 48 checks passed
@eapolinario eapolinario deleted the unpin-flyteconsole-in-release branch April 3, 2024 21:15
Jeinhaus pushed a commit to Jeinhaus/flyte that referenced this pull request Apr 8, 2024
…lyteorg#5176)

This reverts commit 68a3415.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants