Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin flyteconsole version in release process #5037

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

#5036

Why are the changes needed?

We cannot release the flyteconsole revamp before Schedules are implemented.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (bcd81b6) to head (d2dc4e9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5037   +/-   ##
=======================================
  Coverage   58.99%   59.00%           
=======================================
  Files         645      645           
  Lines       55551    55578   +27     
=======================================
+ Hits        32773    32792   +19     
- Misses      20187    20194    +7     
- Partials     2591     2592    +1     
Flag Coverage Δ
unittests 59.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) March 12, 2024 01:08
@eapolinario eapolinario merged commit 68a3415 into master Mar 12, 2024
48 checks passed
@eapolinario eapolinario deleted the fix-flyteconsole-to-1.10.3 branch March 12, 2024 01:08
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 12, 2024
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario added a commit that referenced this pull request Apr 3, 2024
This reverts commit 68a3415.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario added a commit that referenced this pull request Apr 3, 2024
This reverts commit 68a3415.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Jeinhaus pushed a commit to Jeinhaus/flyte that referenced this pull request Apr 8, 2024
…lyteorg#5176)

This reverts commit 68a3415.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants