-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key-value execution tags #5453
Key-value execution tags #5453
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5453 +/- ##
==========================================
- Coverage 61.07% 60.99% -0.09%
==========================================
Files 793 793
Lines 51226 51295 +69
==========================================
- Hits 31288 31287 -1
- Misses 17062 17128 +66
- Partials 2876 2880 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good. Left a few comments.
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Tracking issue
#3960
Why are the changes needed?
The current execution tag is a hash tag (key-only tag), but we want to support a key-value tag. The key is required, but the value is optional. That said, you can still use a hash tag by not providing a value.
What changes were proposed in this pull request?
Tables
execution_admin_tags
tableadmin_tags
tableexecution_tags
tableTo keep backward compatibility, both labels and tags in the executionSpc will be added to the new
execution_tags
table.Endpoint to get the workflows with tags
The old filter still works, and it will get the tag from the new table
How was this patch tested?
local sandbox
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA