Key-value execution tags

[pingsutw]

Tracking issue

#3960

Why are the changes needed?

The current execution tag is a hash tag (key-only tag), but we want to support a key-value tag. The key is required, but the value is optional. That said, you can still use a hash tag by not providing a value.

What changes were proposed in this pull request?

Tables

• Drop execution_admin_tags table
• Drop admin_tags table
• Add execution_tags table

To keep backward compatibility, both labels and tags in the executionSpc will be added to the new execution_tags table.

Endpoint to get the workflows with tags

• Get: http://localhost:30080/api/v1/executions/flytesnacks/development/f6e2ba11a96c24e79a88
• List: http://localhost:30080/api/v1/executions/flytesnacks/development?limit=5
• List with filter: http://localhost:30080/api/v1/executions/flytesnacks/development?filters=value_in(execution_tag.key,flyte%3Btest)&limit=25&sort_by.direction=DESCENDING&sort_by.key=created_at
• List with filter: http://localhost:30080/api/v1/executions/flytesnacks/development?filters=value_in(execution_tag.value,hello%3Brust)&limit=25&sort_by.direction=DESCENDING&sort_by.key=created_at

The old filter still works, and it will get the tag from the new table

• List with filter: http://localhost:30080/api/v1/executions/flytesnacks/development?filters=value_in(admin_tag.name,flyte%3Btest)&limit=25&sort_by.direction=DESCENDING&sort_by.key=created_at

How was this patch tested?

local sandbox

pyflyte run --remote --label tokio=3 --label rust=6 flyte-example/getting_started.py wf
pyflyte run --remote --tag 123 --tag 456 flyte-example/getting_started.py wf 

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

NA

Docs link

NA

[codecov]

Codecov Report

Attention: Patch coverage is 24.32432% with 84 lines in your changes missing coverage. Please review.

Project coverage is 60.99%. Comparing base (25c3596) to head (5684388).

Files	Patch %	Lines
flyteadmin/pkg/repositories/config/migrations.go	0.00%	32 Missing ⚠️
...teadmin/pkg/repositories/transformers/execution.go	0.00%	24 Missing ⚠️
flyteadmin/pkg/manager/impl/execution_manager.go	50.00%	17 Missing and 1 partial ⚠️
...eadmin/pkg/repositories/gormimpl/execution_repo.go	53.84%	3 Missing and 3 partials ⚠️
flyteadmin/pkg/common/filters.go	33.33%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5453      +/-   ##
==========================================
- Coverage   61.07%   60.99%   -0.09%     
==========================================
  Files         793      793              
  Lines       51226    51295      +69     
==========================================
- Hits        31288    31287       -1     
- Misses      17062    17128      +66     
- Partials     2876     2880       +4     

Flag	Coverage Δ
unittests-datacatalog	69.31% <ø> (ø)
unittests-flyteadmin	58.62% <24.32%> (-0.29%)	⬇️
unittests-flytecopilot	17.79% <ø> (ø)
unittests-flytectl	67.97% <ø> (ø)
unittests-flyteidl	79.04% <ø> (ø)
unittests-flyteplugins	61.94% <ø> (ø)
unittests-flytepropeller	57.32% <ø> (ø)
unittests-flytestdlib	65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eapolinario]

This is looking pretty good. Left a few comments.