Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling issues #5580

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Fix spelling issues #5580

merged 4 commits into from
Jul 23, 2024

Conversation

nnsW3
Copy link
Contributor

@nnsW3 nnsW3 commented Jul 23, 2024

Hello
I found some spelling issues in your docs.
Glad I could help.

Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com>
Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com>
Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com>
Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com>
Copy link

welcome bot commented Jul 23, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.99%. Comparing base (3082cd3) to head (ee56fde).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5580      +/-   ##
==========================================
- Coverage   35.02%   33.99%   -1.04%     
==========================================
  Files        1204     1135      -69     
  Lines      104634   102008    -2626     
==========================================
- Hits        36653    34679    -1974     
+ Misses      64065    63723     -342     
+ Partials     3916     3606     -310     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 53.72% <ø> (-0.02%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl ?
unittests-flyteidl 7.09% <ø> (ø)
unittests-flyteplugins 53.31% <ø> (ø)
unittests-flytepropeller 41.75% <ø> (ø)
unittests-flytestdlib 55.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit a07753e into flyteorg:master Jul 23, 2024
48 of 50 checks passed
Copy link

welcome bot commented Jul 23, 2024

Congrats on merging your first pull request! 🎉

vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com>
Signed-off-by: Vladyslav Libov <vladyslav.libov@d-fine.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants