This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Do not depend on GOPATH to locate test data #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GOPATH is not mandatory to have now and the source code may not be stored under GOPATH.
honnix
requested review from
anandswaminathan,
EngHabu,
katrogan,
kumare3,
matthewphsmith and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
- Coverage 62.39% 62.34% -0.05%
==========================================
Files 104 104
Lines 7752 7758 +6
==========================================
Hits 4837 4837
- Misses 2345 2351 +6
Partials 570 570
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kumare3
reviewed
Sep 2, 2020
| } | ||
|
|
||
| configAccessor := viper.NewAccessor(config.Options{ | ||
| SearchPaths: searchPaths, | ||
| SearchPaths: []string{filepath.Join(pwd, "../testdata", fileName)}, |
There was a problem hiding this comment.
Thank you so much, but what do you think about moving the test yaml to this folder?
There was a problem hiding this comment.
does not need to part of this change, we can file a bug and handle it as a follow up.
There was a problem hiding this comment.
Yeah I prefer that in a separated PR because it is not really part of this fix.
This was referenced Sep 3, 2020
schottra
added a commit
that referenced
this pull request
Sep 8, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
GOPATH is not mandatory to have now and the source code may not be stored under GOPATH.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
GOPATH is not mandatory to have now and the source code may not be stored under GOPATH.
Type
Are all requirements met?
Complete description
Use
os.Getwd()to get current directory and then join path.Tracking Issue
flyteorg/flyte#498
Follow-up issue