feat: Fetch Node Executions directly if possible #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 69.37% 70.04% +0.67%
==========================================
Files 383 383
Lines 6299 6337 +38
Branches 986 997 +11
==========================================
+ Hits 4370 4439 +69
+ Misses 1929 1898 -31
Continue to review full report at Codecov.
|
BobNisco
approved these changes
Oct 20, 2020
schottra
changed the title
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Oct 20, 2020
# [0.14.0](http://github.com/lyft/flyteconsole/compare/v0.13.2...v0.14.0) (2020-10-20) ### Features * Fetch Node Executions directly if possible ([#109](http://github.com/lyft/flyteconsole/issues/109)) ([c740b83](http://github.com/lyft/flyteconsole/commit/c740b83c08b0d9da94c3b54d88481fb5817cd71c))
|
🎉 This PR is included in version 0.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#438
This builds on the work from flyteorg/flyteadmin#111 to directly query NodeExecution children for NodeExecutions which use the new
isParentflag. Most of the work was in theuseChildNodeExecutionsanduseExecutionDataCachehooks to use the right logic for building a query for the node_executions endpoint.