Fixes the AppInfo window value for GA #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Porter <jason@union.ai>
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
- Coverage 68.31% 68.31% -0.01%
==========================================
Files 448 448
Lines 10672 10673 +1
Branches 1840 1841 +1
==========================================
Hits 7291 7291
- Misses 3381 3382 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
olga-union
approved these changes
Dec 16, 2022
ursucarina
approved these changes
Dec 16, 2022
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Porter jason@union.ai
This PR fixes and issue reported by users that the value displayed in the AppInfo component would always return true for "Google Analytics" even when it was actually disabled/not-loaded.
Type
Are all requirements met?
fixes https://github.com/flyteorg/flyte/issues/613
Follow-up issue
NA