Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix crash #746

Merged
merged 1 commit into from
Apr 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/console/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@flyteorg/console",
"version": "0.0.21",
"version": "0.0.22",
"description": "Flyteconsole main app module",
"main": "./dist/index.js",
"module": "./lib/index.js",
Expand Down
7 changes: 4 additions & 3 deletions packages/console/src/components/hooks/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export function extractCompiledNodes(

return subWorkflows.reduce((out, subWorkflow) => {
return [...out, ...subWorkflow.template.nodes];
}, primary?.template?.nodes);
}, primary?.template?.nodes || []);
}

export function extractTaskTemplates(workflow: Workflow): TaskTemplate[] {
Expand All @@ -32,10 +32,11 @@ export function extractAndIdentifyNodes(
if (!workflow.closure || !workflow.closure.compiledWorkflow) {
return [];
}
const { primary, subWorkflows = [] } = workflow.closure.compiledWorkflow;
const { primary = {} as CompiledWorkflow, subWorkflows = [] } =
workflow.closure.compiledWorkflow;
const nodes = subWorkflows.reduce(
(out, subWorkflow) => [...out, ...subWorkflow.template.nodes],
primary.template.nodes,
primary?.template?.nodes || [],
);

return nodes.map(node => ({
Expand Down
2 changes: 1 addition & 1 deletion website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"dependencies": {
"@flyteorg/common": "^0.0.4",
"@flyteorg/console": "^0.0.21",
"@flyteorg/console": "^0.0.22",
"long": "^4.0.0",
"protobufjs": "~6.11.3",
"react-ga4": "^1.4.1",
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1995,7 +1995,7 @@ __metadata:
resolution: "@flyteconsole/client-app@workspace:website"
dependencies:
"@flyteorg/common": ^0.0.4
"@flyteorg/console": ^0.0.21
"@flyteorg/console": ^0.0.22
"@types/long": ^3.0.32
long: ^4.0.0
protobufjs: ~6.11.3
Expand Down Expand Up @@ -2034,7 +2034,7 @@ __metadata:
languageName: unknown
linkType: soft

"@flyteorg/console@^0.0.21, @flyteorg/console@workspace:packages/console":
"@flyteorg/console@^0.0.22, @flyteorg/console@workspace:packages/console":
version: 0.0.0-use.local
resolution: "@flyteorg/console@workspace:packages/console"
dependencies:
Expand Down