Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Added script for checking diff of generated code #30

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Dec 2, 2021

TL;DR

  • Added check for verify go-gen, it will fail if contributor forget to generate code

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#1872

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Yuvraj <code@evalsocket.dev>
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #30 (a91fba5) into master (6765776) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   17.79%   17.79%           
=======================================
  Files           3        3           
  Lines         399      399           
=======================================
  Hits           71       71           
  Misses        315      315           
  Partials       13       13           
Flag Coverage Δ
unittests 16.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6765776...a91fba5. Read the comment docs.

Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
@yindia yindia merged commit cd60809 into master Dec 6, 2021
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Added ci check for go generate

Signed-off-by: Yuvraj <code@evalsocket.dev>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants