Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Proposal : Settings proto #297

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Proposal : Settings proto #297

wants to merge 2 commits into from

Conversation

pmahindrakar-oss
Copy link
Contributor

@pmahindrakar-oss pmahindrakar-oss commented May 5, 2022

Signed-off-by: Prafulla Mahindrakar prafulla.mahindrakar@gmail.com

TL;DR

Proposed usage from flytectl

Get setting

  • Get Full settings
    flytectl get settings -o yaml -settingFile full_settings.yaml

  • Generate a sample full settings
    flytectl get settings -o yaml -settingFile full_settings.yaml --gen

  • Global settings
    flytectl get settings --global -o yaml -settingFile global_settings.yaml

  • Generate a sample global settings
    flytectl get settings --global -o yaml -settingFile global_settings.yaml --gen

  • project setting
    flytectl get settings -p project -settingFile project_settings.yaml

  • Generate a sample project settings
    flytectl get settings -p project -o yaml -settingFile project_settings.yaml --gen

  • domain settings
    flytectl get settings -p project -d domain -settingFile domain_settings.yaml

  • Generate a sample domain settings
    flytectl get settings -p project -d domain -o yaml -settingFile domain_settings.yaml --gen

  • workflow settings
    flytectl get settings -p project -d domain workflow -settingFile workflow_settings.yaml

  • Generate a sample workflow settings
    flytectl get settings -p project -d domain -o yaml -settingFile workflow_settings.yaml --gen

  • launchplan settings
    flytectl get settings -p project -d domain launchplan -settingFile launchplan_settings.yaml

  • Generate a sample launchplan settings
    flytectl get settings -p project -d domain launchplan -o yaml -settingFile launchplan_settings.yaml --gen

Update setting

  • Update Full settings
    flytectl update settings --settingFile settings.yaml

  • Global settings
    flytectl update settings --global -settingFile global_settings.yaml

  • project setting
    flytectl update settings -p project -settingFile project_settings.yaml

  • domain settings
    flytectl update settings -p project -d domain -settingFile domain_settings.yaml

  • workflow settings
    flytectl update settings -p project -d domain workflow -settingFile workflow_settings.yaml

  • launchplan settings
    flytectl update settings -p project -d domain launchplan -settingFile launchplan_settings.yaml

Delete setting

  • Global settings
    flytectl delete settings --global

  • project setting
    flytectl delete settings -p project

  • domain settings
    flytectl delete settings -p project -d domain

  • workflow settings
    flytectl delete settings -p project -d domain workflow

  • launchplan settings
    flytectl delete settings -p project -d domain launchplan

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#2322
flyteorg/flyte#2070

Follow-up issue

NA

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #297 (1ebaf87) into master (e749b82) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   74.77%   74.77%           
=======================================
  Files          15       15           
  Lines         991      991           
=======================================
  Hits          741      741           
  Misses        218      218           
  Partials       32       32           
Flag Coverage Δ
unittests 75.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e749b82...1ebaf87. Read the comment docs.

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant