This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Use buf to generate python stubs #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
- Coverage 75.46% 73.12% -2.35%
==========================================
Files 18 18
Lines 1174 1362 +188
==========================================
+ Hits 886 996 +110
- Misses 237 315 +78
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
wild-endeavor
previously approved these changes
Nov 29, 2022
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
pingsutw
approved these changes
Nov 29, 2022
| run: python3 /usr/local/bin/entrypoint.py -i ./protos -d protos/flyteidl/plugins -l python | ||
| - name: Proto-Datacatalog-Python | ||
| run: python3 /usr/local/bin/entrypoint.py -i ./protos -d protos/flyteidl/datacatalog -l python | ||
| # - name: Proto-Service-Python |
There was a problem hiding this comment.
This will all be removed once we move the other plugins to buf. Leaving it like this is a good indication that we're in this in-between state.
wild-endeavor
approved these changes
Nov 29, 2022
8 tasks
eapolinario
added a commit
that referenced
this pull request
Feb 22, 2023
This reverts commit f4ede35. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
added a commit
that referenced
this pull request
Sep 8, 2023
* Buf python migration Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Generate pyi files Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add venv to .gitgnore Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use buf to generate python stubs Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use buf docker image to generate stubs Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add stubs produced by call to `buf generate` using buf's docker image Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add pyi files Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use buf locally Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Verify that generated protos by using buf Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Copy generated code to a separate artifact Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Move back to go_generate.yml@master Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Use buf to generate python stubs and pyi files
Type
Are all requirements met?
Complete description
As described in https://developers.google.com/protocol-buffers/docs/news/2022-05-06, starting on version 4.21.0, the python protobuf package is based on the upb library. This requires us to remove the upper bound we put on the
protobufpackage if we are to leverage these new features. We are also receiving a fair amount of questions regarding the supported version ofprotobuffrom Flyte users, so all in all it's a good time to relax that constraint.This PR does two things:
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/