This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Fix python package and publish typing information #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 73.12% 73.12%
=======================================
Files 18 18
Lines 1362 1362
=======================================
Hits 996 996
Misses 315 315
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
wild-endeavor
approved these changes
Nov 30, 2022
pingsutw
approved these changes
Nov 30, 2022
eapolinario
added a commit
that referenced
this pull request
Feb 22, 2023
This reverts commit b4a6a57. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
added a commit
that referenced
this pull request
Sep 8, 2023
* Add __init__.py files to generated stubs Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Publish stubs in the package Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Include __init__.py in verification workflow Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Bump versions of remote plugins Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Necessary init.py files were removed in #346
Type
Are all requirements met?
Complete description
The python protoc plugin does not leave
__init__.pyin the generated code, which makes it hard for code likesetuptoolsto package the generated stub code. We do something similar in https://github.com/backup-test-123/protogen/blob/first-commit/generate_protos.py#L171-L181 and in this PR puts those files back and leave some code ingenerate_protos.shto generate those files.This PR also publishes the typing information contained in the pyi files by specifying them in the
package_datasection insetuptools.setup.I tested this by producing a wheel and testing it on a clean virtual environment. Here's a screenshot of this PR working in emacs:
On the left I'm showing the existing model file defined in flytekit and on the right hand side we can see a script importing the stub directly and having access to the field named
closure.Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/