Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Build run on all branches #172

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Make Build run on all branches #172

merged 1 commit into from
Jan 19, 2023

Conversation

RRap0so
Copy link
Collaborator

@RRap0so RRap0so commented Jan 19, 2023

TL;DR

Remove the pull_request condition so the build runs in all PRs (not just master)

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@RRap0so RRap0so requested a review from narape January 19, 2023 06:32
Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
@narape narape merged commit ebc38e2 into master Jan 19, 2023
@narape narape deleted the remove_config branch January 19, 2023 16:14
andresgomezfrr pushed a commit that referenced this pull request Jan 24, 2023
Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>

Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Signed-off-by: Andres Gomez Ferrer <andresg@spotify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants