#patch Fix restriction on maps/collections nesting #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschuchart-spot
force-pushed
the
sdkliteraltype-nesting
branch
from
9ceac11
to
3c6a085
Compare
jschuchart-spot
commented
Jul 5, 2024
| @@ -72,87 +73,17 @@ object SdkLiteralTypes { | |||
| blobs(BlobType.DEFAULT).asInstanceOf[SdkLiteralType[T]] | |||
| case t if t =:= typeOf[Binary] => | |||
| binary().asInstanceOf[SdkLiteralType[T]] | |||
|
|
|||
| case t if t <:< typeOf[List[Any]] => | |||
There was a problem hiding this comment.
technically, List[T] is also a Product, so I'm not sure how this match worked before
jschuchart-spot
commented
Jul 5, 2024
| @@ -369,28 +301,6 @@ object SdkLiteralTypes { | |||
| } | |||
| } | |||
|
|
|||
| def createTypeTag[U <: Product](tpe: Type): TypeTag[U] = { | |||
There was a problem hiding this comment.
pulled out to further down, so it is accessible in .of()
jschuchart-spot
commented
Jul 5, 2024
Comment on lines
419
to
420
| val typeRef = | ||
| universe.internal.typeRef(NoPrefix, typSym, tpe.typeArgs) |
There was a problem hiding this comment.
Had to add the tpe.typeArgs as the last argument instead of List.empty as it would otherwise create a type tag e.g. for List instead of List[String], which messes up the recursion
andresgomezfrr
force-pushed
the
sdkliteraltype-nesting
branch
from
433e1cd
to
e647d77
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Removing the restriction on nesting depth for collections and maps
Type
Are all requirements met?
Complete description
Removing the restriction on nesting depth for collections and maps. This simplifies the matching expression for SdkLiteralTypes.
This reuses the logic for creating TypeTags for a given type (-name) on the fly to make
SdkLiteralTypes.of(...)recursive.Tracking Issue
NA
Follow-up issue
NA