Restrict numpy due to deprecated aliases #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
requested review from
wild-endeavor,
kumare3 and
pingsutw
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1376 +/- ##
=======================================
Coverage 69.07% 69.07%
=======================================
Files 298 298
Lines 27428 27428
Branches 2568 2568
=======================================
Hits 18946 18946
Misses 7979 7979
Partials 503 503
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wild-endeavor
approved these changes
Dec 19, 2022
pingsutw
approved these changes
Dec 19, 2022
eapolinario
added a commit
that referenced
this pull request
Dec 19, 2022
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
8 tasks
eapolinario
added a commit
that referenced
this pull request
Dec 19, 2022
…#1377) * Restrict numpy due to deprecated aliases (#1376) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Backport part of 1365 - fix papermill plugins dev-requirements Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eduardo Apolinario eapolinario@users.noreply.github.com
TL;DR
Restrict numpy version before removing deprecated numpy aliases
Type
Are all requirements met?
Complete description
In numpy 1.20.0 some type aliases were marked as deprecated and those were finallly removed in version 1.24.0, which was released last night and broke default installations of flytekit.
Tracking Issue
flyteorg/flyte#3166
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/