removes references to unused plugins #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the awssagemaker plugin is deprecated (doesn't work anymore) and will be replaced with a sagemaker agent. - the fsspec plugin is a stub library Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
pingsutw
previously approved these changes
Dec 6, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2025 +/- ##
=======================================
Coverage 85.91% 85.91%
=======================================
Files 306 306
Lines 22818 22818
Branches 3466 3466
=======================================
+ Hits 19604 19605 +1
Misses 2622 2622
+ Partials 592 591 -1 ☔ View full report in Codecov by Sentry. |
eapolinario
previously approved these changes
Dec 6, 2023
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
3 tasks
eapolinario
approved these changes
Dec 6, 2023
pingsutw
approved these changes
Dec 6, 2023
2 tasks
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Dec 12, 2023
* removes references to unused plugins - the awssagemaker plugin is deprecated (doesn't work anymore) and will be replaced with a sagemaker agent. - the fsspec plugin is a stub library Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * comment out sagemaker test Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Future Outlier <eric901201@gmai.com>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* removes references to unused plugins - the awssagemaker plugin is deprecated (doesn't work anymore) and will be replaced with a sagemaker agent. - the fsspec plugin is a stub library Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * comment out sagemaker test Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
What changes were proposed in this pull request?
Removing references of the fsspec and awssagemaker plugins.
How was this patch tested?
Docs are built locally and in CI/CD