changing permissions of /tmp #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario and
cosmicBboy
as code owners
eapolinario
reviewed
Dec 6, 2023
plugins/flytekit-flyin/Dockerfile
Outdated
| && chown flytekit: /home \ | ||
| && chown -R flytekit:flytekit /tmp \ | ||
| && chmod 755 /tmp | ||
| && chown flytekit: /home |
There was a problem hiding this comment.
can you add a newline && : and a \ to this line?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2026 +/- ##
==========================================
+ Coverage 85.90% 85.91% +0.01%
==========================================
Files 306 306
Lines 22818 22818
Branches 3466 3466
==========================================
+ Hits 19601 19605 +4
+ Misses 2625 2622 -3
+ Partials 592 591 -1 ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
Dec 6, 2023
|
The failing test is what I'm fixing in #2025, we can merge this |
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* changing permissions of /tmp Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fix envd unit test. https://github.com/flyteorg/flytekit/actions/runs/7118907266/job/19383987236?pr=2025
What changes were proposed in this pull request?
Use default permission
777for/tmpHow was this patch tested?
Manually build an image
Setup process
Screenshots
Check all the applicable boxes