Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent uploads input.pb even if task input is None #2054

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Dec 14, 2023

Tracking issue

flyteorg/flyte#3936

Why are the changes needed?

Agent failed to run a PythonFunctionTask remotely since input.pb was not found.

What changes were proposed in this pull request?

Upload empty input.pb even if the input is None since --inputs is required by the pyflyte-execute command

@_click.option("--inputs", required=True)

How was this patch tested?

Run an agent task locally

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (530ad26) 83.18% compared to head (6403e0e) 86.00%.
Report is 6 commits behind head on master.

Files Patch % Lines
flytekit/extend/backend/base_agent.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2054      +/-   ##
==========================================
+ Coverage   83.18%   86.00%   +2.81%     
==========================================
  Files         173      308     +135     
  Lines       16840    22945    +6105     
  Branches     3471     3468       -3     
==========================================
+ Hits        14009    19734    +5725     
- Misses       2236     2611     +375     
- Partials      595      600       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 7f7272f into master Dec 15, 2023
74 of 75 checks passed
@pingsutw pingsutw mentioned this pull request Jan 3, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants