Local Sync Agent #2085
Merged
Local Sync Agent #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2085 +/- ##
==========================================
- Coverage 85.73% 83.84% -1.90%
==========================================
Files 313 313
Lines 23435 23442 +7
Branches 3512 3514 +2
==========================================
- Hits 20093 19655 -438
- Misses 2734 3165 +431
- Partials 608 622 +14 ☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Jan 3, 2024
| class AsyncAgentExecutorMixin: | ||
| """ | ||
| This mixin class is used to run the agent task locally, and it's only used for local execution. | ||
| Task should inherit from this class if the task can be run in the agent. | ||
| It can handle asynchronous tasks and synchronous tasks. | ||
| Asynchronous tasks are for tasks running long, for example, running query job. |
There was a problem hiding this comment.
Suggested change
| Asynchronous tasks are for tasks running long, for example, running query job. | |
| Asynchronous tasks are tasks that take a long time to complete, such as running a query. |
added 2 commits
January 3, 2024 22:29
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
added 4 commits
January 3, 2024 23:56
change Signed-off-by: Future Outlier <eric901201@gmai.com>
…nto sync-agent-architecture
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
pingsutw
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#3936
Why are the changes needed?
We want to support synchronous tasks in the agent.
What changes were proposed in this pull request?
Add sync agent local execution mode.
How was this patch tested?
I test this patch in this chatgpt agent PR.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
#1822
#2086