-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constraint the full fsspec family #2087
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2087 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 313 313
Lines 23426 23426
Branches 3510 3510
=======================================
Hits 20092 20092
Misses 2727 2727
Partials 607 607 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
073f231
to
890751e
Compare
@honnix curious if you have a sense of what it'd take to increase the upper range here? I tried (and failed) to bump it for flyte but couldn't decipher the windows errors. |
@mark-thm I think you will need to bump all those packages to a matching version. They are usually matched on "20xx.x" level but there seems to be exceptions. |
I would be very interested in bumping the upper range. There is actually no version of It seems to me like its largely the user's responsibility to ensure that fsspec packages are aligned. I don't see how it can be done on a flyte level without restricting to a very tight range. |
Yeah, the fsspec package versions are tricky. |
Personally I think I would be in favour of removing all the upper limits, so that users have control. I'm definitely going to want to use a new version of adlfs once fsspec/adlfs#389 gets resolved. |
I just discovered that each version of
I haven't found where the constraint is in the code for |
It looks like #2143 has addressed this |
Tracking issue
Closes flyteorg/flyte#4665
Why are the changes needed?
Described in flyteorg/flyte#4665
What changes were proposed in this pull request?
Use the same constraint for all packages from fsspec family
How was this patch tested?
Through CI probably.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link