Remove upper version bound from fsspec #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@gmail.com>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario and
cosmicBboy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
==========================================
- Coverage 85.57% 85.53% -0.05%
==========================================
Files 308 308
Lines 23113 23116 +3
Branches 3540 3541 +1
==========================================
- Hits 19779 19772 -7
- Misses 2722 2729 +7
- Partials 612 615 +3 ☔ View full report in Codecov by Sentry. |
|
Hey @pingsutw I could really use this as the current upper bound limits botocore to pre-aws bedrock releases (llms in flyte are awesome!). I see some of the windows CICD is failing -- are they false positives? Can this be merged? Appreciate any attention you can give this. |
Signed-off-by: Kevin Su <pingsutw@gmail.com>
flytekit/types/directory/types.py
Outdated
| @@ -431,6 +428,8 @@ def to_literal( | |||
| if should_upload: | |||
| if remote_directory is None: | |||
| remote_directory = ctx.file_access.get_random_remote_directory() | |||
| if not os.path.isdir(source_path): | |||
There was a problem hiding this comment.
can we use pathlib.Path().is_dir?
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
approved these changes
Feb 6, 2024
|
@pingsutw Thank you so very much! You're a rock star! |
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Allow users to use the latest
fsspecby removing the upper-bound.What changes were proposed in this pull request?
remove the upper-bound
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes