check #2486
Merged
check #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy and
samhita-alla
as code owners
EngHabu
approved these changes
Jun 17, 2024
EngHabu
merged commit 9825b4e
into
array-node-input-transformation
42 of 45 checks passed
EngHabu
added a commit
that referenced
this pull request
Jun 17, 2024
* Only transform the literal that matches the map task index Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * kevin's update Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * make it work locally Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * add a test Signed-off-by: Kevin Su <pingsutw@apache.org> * check (#2486) Signed-off-by: Kevin Su <pingsutw@apache.org> * Only fail for unbound batch pickled inputs for map tasks Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org>
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
…2484) * Only transform the literal that matches the map task index Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * kevin's update Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * make it work locally Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * add a test Signed-off-by: Kevin Su <pingsutw@apache.org> * check (flyteorg#2486) Signed-off-by: Kevin Su <pingsutw@apache.org> * Only fail for unbound batch pickled inputs for map tasks Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: bugra.gedik <bugra.gedik@predera.ai>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Only transform the literal that matches the map task index Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * kevin's update Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * make it work locally Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * add a test Signed-off-by: Kevin Su <pingsutw@apache.org> * check (#2486) Signed-off-by: Kevin Su <pingsutw@apache.org> * Only fail for unbound batch pickled inputs for map tasks Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link