This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
persisting k8s plugin phase, version, and reason #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <daniel@union.ai>
8 tasks
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 62.87% 63.98% +1.10%
==========================================
Files 146 146
Lines 12168 9902 -2266
==========================================
- Hits 7651 6336 -1315
+ Misses 3940 2984 -956
- Partials 577 582 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 125 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pingsutw
previously approved these changes
Mar 27, 2023
EngHabu
previously approved these changes
Mar 27, 2023
Signed-off-by: Daniel Rammer <daniel@union.ai>
pingsutw
approved these changes
Mar 27, 2023
eapolinario
approved these changes
Mar 27, 2023
8 tasks
2 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* using PhaseVersion to ensure Reason updates are sent Signed-off-by: Daniel Rammer <daniel@union.ai> * refactored and fixed tests Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed linter Signed-off-by: Daniel Rammer <daniel@union.ai> * added docs Signed-off-by: Daniel Rammer <daniel@union.ai> * corrected missing old usecase Signed-off-by: Daniel Rammer <daniel@union.ai> * actually this will work Signed-off-by: Daniel Rammer <daniel@union.ai> * added missing increment on phsae version - thanks yee Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR adds support for persisting state of k8s plugins including Phase, PhaseVersion, and Reason. This is used to detect scenarios where the
Reasonhas been updated and update thePhaseVersionto ensure that the latestReasonis reported to FlyteAdmin in aTaskExecutionEvent.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3440
Follow-up issue
NA