This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Plugin changes for plumbing k8s events into TaskExecutionEvent #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #406 +/- ##
==========================================
+ Coverage 62.73% 64.19% +1.46%
==========================================
Files 156 156
Lines 13172 10705 -2467
==========================================
- Hits 8263 6872 -1391
+ Misses 4284 3202 -1082
- Partials 625 631 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hamersaw
reviewed
Sep 27, 2023
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
hamersaw
approved these changes
Sep 27, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 28, 2023
* Plugin changes for k8s events Signed-off-by: Andrew Dye <andrewwdye@gmail.com> * make generate Signed-off-by: Andrew Dye <andrewwdye@gmail.com> * Comment for SendObjectEvents Signed-off-by: Andrew Dye <andrewwdye@gmail.com> * make generate Signed-off-by: Andrew Dye <andrewwdye@gmail.com> --------- Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
State management and config changes required for plumbing k8s events into
TaskExecutionEventas part of flyteorg/flyte#3825Type
Are all requirements met?
Complete description
This change
TaskInfo.AdditionalReasonsfield so that propeller can append k8s event information when handling a k8s phase update.SendObjectEventsoption to K8sPluginConfig so this feature can be opted intoTracking Issue
flyteorg/flyte#3825
Follow-up issue
N/A