This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fast fail if task resource requests exceed k8s resource limits #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
wild-endeavor
approved these changes
Oct 7, 2022
|
This would be helpful! Anything missing here? |
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
…org#488) * checking if task resource requests exceed k8s limits Signed-off-by: Daniel Rammer <daniel@union.ai> * added better message to task failure Signed-off-by: Daniel Rammer <daniel@union.ai> * added request checks Signed-off-by: Daniel Rammer <daniel@union.ai> * added tests for checking resource eligibility Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed lint issues Signed-off-by: Daniel Rammer <daniel@union.ai> * updated comment Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai>
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
When encountering a "ResourceExceedsLimits" error from k8s we validate that the task resource requests and limits are below the k8s resource quota. Otherwise the task will never be schedule-able and will forever hang until FlytePropeller terminates it based on
node-active-duration.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#2933
Follow-up issue
NA